Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rename Deno.Server to Deno.HttpServer #20842

Merged
merged 2 commits into from
Oct 27, 2023

Conversation

lucacasonato
Copy link
Member

@lucacasonato lucacasonato commented Oct 9, 2023

Keeps the old name around for backwards compat.

Closes #20840

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Keeps the old name around for backwards compat.
@lucacasonato lucacasonato force-pushed the rename_server_to_httpserver branch from 074f4a4 to 90419d7 Compare October 9, 2023 08:07
@lucacasonato lucacasonato added this to the 1.38 milestone Oct 9, 2023
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine, but I'm gonna mark it as "Request changes" so we don't land it by mistake before v1.38. I'll make sure this is included in the minor release.

@mmastrac
Copy link
Contributor

mmastrac commented Oct 9, 2023

LGTM to land in 1.38!

Signed-off-by: Bartek Iwańczuk <biwanczuk@gmail.com>
@bartlomieju bartlomieju merged commit 9a97edc into denoland:main Oct 27, 2023
@bartlomieju bartlomieju deleted the rename_server_to_httpserver branch October 27, 2023 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename Deno.Server to Deno.HttpServer
3 participants