feat(unstable): ability to npm install then deno run main.ts
#20967
+935
−218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
commented
Oct 25, 2023
bartlomieju
reviewed
Oct 25, 2023
dsherret
commented
Oct 25, 2023
| if let Some(resolver) = | ||
| self.npm_resolver.as_ref().and_then(|r| r.as_byonm()) | ||
| { | ||
| match &result { |
There was a problem hiding this comment.
For the future, this is the point where we need to make the most improvement. Essentially, we need a way to determine if a specifier is indeed for an npm package and then we need to ensure we surface the appropriate error messages when it fails.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new unstable "bring your own node_modules" (BYONM) functionality currently behind a
--unstable-byonmflag ("unstable": ["byonm"]in a deno.json).This enables users to run a separate install command (ex.
npm install,pnpm install) then rundeno run main.tsand Deno will respect the layout of the node_modules directory as setup by the separate install command. It also works with npm/yarn/pnpm workspaces.For this PR, the behaviour is opted into by specifying
--unstable-byonm/"unstable": ["byonm"], but in the future we may make this the default behaviour as outlined in #18967 (comment)This is an extremely rough initial implementation. Errors are terrible in this and the LSP requires frequent restarts. Improvements will be done in follow up PRs.
Part of #18967