-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: granular --unstable-* flags #20968
feat: granular --unstable-* flags #20968
Conversation
I am generally in favor of this, but also |
There are potentially many unstable features for Worker API (eg. loading an import map), would we really want separate flags for each of these features if they are contained in |
I think it should be |
I'm fine with that name 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! (once the config file test is added)
This commit adds granular
--unstable-*
flags:These flags are meant to replace a "catch-all" flag - "--unstable", that
gives a binary control whether unstable features are enabled or not. The
downside of this flag that allowing eg. Deno KV API also enables the FFI
API (though the latter is still gated with a permission).
These flags can also be specified in
deno.json
file underunstable
key.Currently, "--unstable" flag works the same way - I will open a follow up
PR that will print a warning when using "--unstable" and suggest to use
concrete "--unstable-*" flag instead. We plan to phase out "--unstable"
completely in Deno 2.