-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ext,runtime): add missing custom inspections #21219
Conversation
It seems that we need to use |
length: this.length, | ||
...ObjectFromEntries(ObjectEntries(proxy)), | ||
}) | ||
length: this.length, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The length
property is now displayed the numeric value preferentially, in accordance with Chrome's behavior.
localStorage.setItem("length", "foo");
console.log(localStorage); // "Storage { length: 1 }"
return `DOMException: ${this[_message]}`; | ||
return this[_error].stack; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DOMException
's stacktrace is displayed like any other Error
object
@crowlKats Please take a look! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, great to have this fixed up. Left some comments.
@crowlKats fixed! |
This unfortunately started breaking the main build in the bench job: https://github.com/denoland/deno/actions/runs/6923517859/job/18831509208 |
I think it is an unrelated flaky failure, since I was able to start the Hono server in my environment without any problem.
|
I think it's
|
SymbolIterator, | ||
SymbolToStringTag, | ||
} = primordials; | ||
import * as webidl from "ext:deno_webidl/00_webidl.js"; | ||
import { createFilteredInspectProxy } from "ext:deno_console/01_console.js"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is likely where the problem is -- we are requiring deno_console from runtime. We can temporarily work around it by adding deno_console
to the url_ops
benchmark but we may need move this function into runtime.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anyway, I deleted the Worker's inspect support #21264
(cherry picked from commit c806fbd)
This PR includes the following fixes:
Deno.customInspect
toDeno.privateCustomInspect
in internal codeSee comments for other minor fixes