feat(fmt): Support .ipynb extension
#21310
Merged
+272
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scarf005
changed the title
.ipynb extension.ipynb extension
scarf005
changed the title
.ipynb extension.ipynb extension
scarf005
force-pushed
the
feat-fmt-ipynb
branch
3 times, most recently
from
e5c7248 to
9048d16
Compare
dsherret
requested changes
Nov 23, 2023
scarf005
added a commit
to scarf005/deno
that referenced
this pull request
Nov 24, 2023
from: denoland#21310 (comment) Co-authored-by: David Sherret <dsherret@users.noreply.github.com>
scarf005
added a commit
to scarf005/deno
that referenced
this pull request
Nov 24, 2023
from: denoland#21310 (comment) Co-authored-by: David Sherret <dsherret@users.noreply.github.com>
scarf005
force-pushed
the
feat-fmt-ipynb
branch
from
c2e0b12 to
d44ffa2
Compare
scarf005
added a commit
to scarf005/deno
that referenced
this pull request
Nov 24, 2023
from: denoland#21310 (comment) Co-authored-by: David Sherret <dsherret@users.noreply.github.com>
scarf005
force-pushed
the
feat-fmt-ipynb
branch
from
d44ffa2 to
07c0505
Compare
scarf005
added a commit
to scarf005/deno
that referenced
this pull request
Nov 24, 2023
from: denoland#21310 (comment) Co-authored-by: David Sherret <dsherret@users.noreply.github.com>
scarf005
force-pushed
the
feat-fmt-ipynb
branch
from
07c0505 to
52d0265
Compare
dsherret
added a commit
that referenced
this pull request
Nov 24, 2023
This is to reduce duplicate dependencies for #21310
dsherret
reviewed
Nov 24, 2023
cli/tests/testdata/fmt/expected_fmt_check_verbose_tests_dir.out
Outdated
Show resolved
Hide resolved
scarf005
added a commit
to scarf005/deno
that referenced
this pull request
Nov 25, 2023
from: denoland#21310 (comment) Co-authored-by: David Sherret <dsherret@users.noreply.github.com>
scarf005
force-pushed
the
feat-fmt-ipynb
branch
from
52d0265 to
44ffc4a
Compare
from: denoland#21310 (comment) Co-authored-by: David Sherret <dsherret@users.noreply.github.com>
scarf005
force-pushed
the
feat-fmt-ipynb
branch
from
44ffc4a to
c26c0df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
outdated
changed to using dprint's jupyter plugin
Questions
Extracting structs
I'm not sure if
cli/tools/fmt.rsis the correct place for 4 struct for jupyter notebook definition. Which module should i move the structs to?Checking whether it's TypeScript notebook
not sure which field is the best. currently using
self.metadata.language_info.name == "typescript"Frequent rebuilds
I'm suspecting
include_str!macro is busting incremental build caches.mutation vs cloning
iterating twice (first: format cells, second: check if changes are identical) sounds inefficient, but i'm slightly against using mutation here.
serde(flatten)is unstableEDIT: fixed by changing from
HashMaptoBTreeMap.related: https://old.reddit.com/r/rust/comments/krgvcu/is_the_iteration_order_of_hashset_deterministic/