Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ext/websocket): don't panic on bad resource id #21431

Merged
merged 2 commits into from
Dec 11, 2023

Conversation

littledivy
Copy link
Member

Verified

This commit was signed with the committer’s verified signature.
KinectTheUnknown David-Joseph Xayavong

Verified

This commit was signed with the committer’s verified signature.
KinectTheUnknown David-Joseph Xayavong
Copy link
Contributor

@mmastrac mmastrac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix

Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to have a test case?

@littledivy
Copy link
Member Author

Not able to reproduce this in a test. Will keep the issue open as this may be a race condition in WebSocket

@littledivy littledivy merged commit 0bee37a into denoland:main Dec 11, 2023
@littledivy littledivy deleted the ws_fix_panic branch December 11, 2023 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants