fix(unstable): Honor granular unstable flags in js runtime

[jcayzac]

This fixes #21434 for BroadcastChannel and WebSocketStream. --unstable still enable both, but granular unstable flags now also work:

• --unstable-net now enables WebSocketStream.
• --unstable-broadcast-channel now enables BroadcastChannel.
• Additionally, there are now tests for all granular unstable flags. Since unsafe-proto already had tests, so I didn't add any for this one.

It also introduces a map to keep track of granular unstable ids without having to sync multiple places.

• Ensure there are tests that cover the changes.
• Ensure cargo test passes.
• Ensure ./tools/format.js passes without changing files.
• Ensure ./tools/lint.js passes.

[CLAassistant]

All committers have signed the CLA.

[jcayzac]

@bartlomieju @crowlKats what do you think of https://github.com/jcayzac/deno/pull/1/files ? Should I add it to this PR?

[bartlomieju]

@bartlomieju @crowlKats what do you think of https://github.com/jcayzac/deno/pull/1/files ? Should I add it to this PR?

That seems okay, but please put contents of 89_granular_flags.js into 90_deno_ns.js directly.

[bartlomieju]

Awesome work @jcayzac. Unfortunately we got some merge conflicts - would you be able to resolve them?

Also it would be great to add a regression test for this problem - maybe you could add a test to cli/tests/integration/run_tests.rs using itest! macro that adds all granular unstable flags, run a JavaScript file that console.log() various APIs that should be only available with these flags (eg. BroadcastChannel, WebSocketStream, Deno.openKv).

[bartlomieju]

Unfortunately I'm still unable to have passing tests even in main on either of my two machines (Intel MBP and AMD PC), so I'll have to rely on CI to tell me if they pass there.

Sorry to hear that, is it because of too much load? FWIW you don't need to run all the tests - you can do cargo run <test_name> to run a single test (or multiple if the name matches) and it should be good enough for this PR 👍 the blast radius of this problem is rather small.

[jcayzac]

I think I resolved all the issues. The tests are now all passing.

[littledivy]

Self note: run startup_time benchbot once CI passes

[bartlomieju]

/bench startup_nop_trivial

[denobot]

startup_nop_trivial

	time	user	system	relative
node	24.012 ms	18.363 ms	6.932 ms	+101.8%
bun	11.899 ms	5.74 ms	7.363 ms	best
deno	14.826 ms	10.067 ms	6.028 ms	+24.6%
deno-baseline	14.829 ms	9.618 ms	6.475 ms	+24.6%

---

start: Fri, 08 Dec 2023 07:32:35 GMT

id: 7d9a61b3-94c6-4700-8550-f75eaa14a770

server: c42a2c10-c86a-471b-b4e7-d968a76af264

[crowlKats]

LGTM, thanks!