Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(lsp): instrument all ops with performance marks #21536

Merged
merged 3 commits into from
Dec 11, 2023

Conversation

bartlomieju
Copy link
Member

@bartlomieju bartlomieju commented Dec 11, 2023

Adds performance measurements for all ops used by the LSP. Also changes
output of "Language server status" page to include more precise information.

Current suspicion is that computing "script version" takes a long time for
some users.

Verified

This commit was signed with the committer’s verified signature.
KinectTheUnknown David-Joseph Xayavong

Verified

This commit was signed with the committer’s verified signature.
KinectTheUnknown David-Joseph Xayavong

Verified

This commit was signed with the committer’s verified signature.
KinectTheUnknown David-Joseph Xayavong
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bartlomieju bartlomieju merged commit 88566ce into denoland:main Dec 11, 2023
@bartlomieju bartlomieju deleted the lsp_instrument_all_ops branch December 11, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants