Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(publish): handle diagnostic outside graph #22310

Merged
merged 1 commit into from
Feb 7, 2024
Merged

fix(publish): handle diagnostic outside graph #22310

merged 1 commit into from
Feb 7, 2024
+51 −2

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Feb 6, 2024 •
edited
Loading

Hacky quick fix. The real fix is a lot more work to do (move the SourceTextInfo into all the diagnostics in order to make this less error pone). I've already started on it, but it will require a lot of downstream crate changes.

Closes #22288

@dsherret dsherret requested a review from lucacasonato February 6, 2024 23:44
@dsherret dsherret mentioned this pull request Feb 6, 2024
Closed
lucacasonato
lucacasonato approved these changes Feb 6, 2024
View reviewed changes
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yikes, love it

@dsherret dsherret merged commit e546848 into denoland:main Feb 7, 2024
15 checks passed
@dsherret dsherret deleted the fix_publish_diagnostic_outside_graph branch February 7, 2024 00:21
littledivy pushed a commit that referenced this pull request Feb 8, 2024
@dsherret @littledivy
fix(publish): handle diagnostic outside graph (#22310)
2ad7e70 
Hacky quick fix. The real fix is a lot more work to do (move the
`SourceTextInfo` into all the diagnostics in order to make this less
error pone). I've already started on it, but it will require a lot of
downstream create changes.

Closes #22288
@dsherret dsherret mentioned this pull request Feb 8, 2024
Merged
dsherret added a commit that referenced this pull request Feb 9, 2024
@dsherret
fix: upgrade to deno_ast 0.33 (#22341)
Loading
Loading status checks…
e5e2c45 
* Uses diagnostics from deno_ast
* Real fix for #22310
* Moves `deno lint --json` code here
* Upgrades swc
   
 Closes #22117
 Closes #22109
 Closes #21927
 Closes #20993
littledivy pushed a commit that referenced this pull request Feb 15, 2024
@dsherret @littledivy
fix: upgrade to deno_ast 0.33 (#22341)
019fae0 
* Uses diagnostics from deno_ast
* Real fix for #22310
* Moves `deno lint --json` code here
* Upgrades swc
   
 Closes #22117
 Closes #22109
 Closes #21927
 Closes #20993
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucacasonato lucacasonato

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

deno publish panics "source text should be in the cache if snippet source is a specifier"
2 participants
@dsherret @lucacasonato