fix(lsp): don't apply preload limit to workspace walk #23123
Merged
+94
−65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
reviewed
Mar 29, 2024
| @@ -1069,8 +1069,7 @@ impl Inner { | |||
|
|
|||
| fn walk_workspace(config: &Config) -> (BTreeSet<ModuleSpecifier>, bool) { | |||
| let mut workspace_files = Default::default(); | |||
| let document_preload_limit = | |||
| config.workspace_settings().document_preload_limit; | |||
| let entry_limit = 1000; | |||
There was a problem hiding this comment.
I don't fully understand this, so I'll have to look at it in the morning, but I'm a bit concerned that a user would run into the same bug again once they have a lot of files.
There was a problem hiding this comment.
They'd need 1000 files at the top level preceding deno.json for that to happen. After the multi-deno.json detection is all set up, if there's demand I want to make some of it more lazy, like scanning upwards for new scopes whenever a file is opened in the editor. Let's leave that for later though.
|
Added fix for #23141. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23121.
Fixes #23141.