fix: retry writing lockfile on failure #24052
Merged
+29
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
commented
May 30, 2024
| loop { | ||
| match atomic_write_file(file_path, data.as_ref(), mode) { | ||
| Ok(()) => return Ok(()), | ||
| Err(err) => { |
There was a problem hiding this comment.
Should we be selective on error kind? Note: atomic_write_file already handles creating the directory when it doesn't exist.
dsherret
commented
May 30, 2024
| @@ -84,7 +84,7 @@ pub fn write_lockfile_if_has_changes( | |||
| }; | |||
| // do an atomic write to reduce the chance of multiple deno | |||
| // processes corrupting the file | |||
| atomic_write_file(&lockfile.filename, bytes, cache::CACHE_PERM) | |||
| atomic_write_file_with_retries(&lockfile.filename, bytes, cache::CACHE_PERM) | |||
There was a problem hiding this comment.
Confirmed this retrying fixed the rare issue I was having in deno_graph's ecosystem tests.
bartlomieju
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into this running the deno_graph ecosystem tests where many processes writing to the same path at the same time would cause an error.