Skip to content
This repository has been archived by the owner on May 17, 2024. It is now read-only.

Add GA #20

Open
lambtron opened this issue Mar 4, 2022 · 2 comments
Open

Add GA #20

lambtron opened this issue Mar 4, 2022 · 2 comments

Comments

@lambtron
Copy link
Contributor

lambtron commented Mar 4, 2022

Adding server side GA so we can measure traffic on the examples page.

UA-property should match the same as deno.land. Shouldn't be an issue due to the same TLD.

@lino-levan
Copy link
Contributor

Would love to get some traffic numbers on denobyexample but I don't think I'm able to push this forward without deeper access to the project.

We've gotten some very positive comments on discord:

yeah the example page is much more helpful

Oh wow. I learned most by trial and error. Wish i knew about this.

I've been inspired by the documentation [at denobyexample]

[This is] amazing! Thanks. I will try this immediately

One common message I'm seeing is something along the lines of "I wish I knew about this sooner" so maybe we should try to link this in a more obvious manner from other deno resources (the manual has a few hard to find links).

Thoughts @hashrock?

@hashrock
Copy link
Contributor

Yeah it's nice to have. Deno by Example is not very well known and needs to be improved.

However, in order to add GA, environment variables need to be added to Deploy, and Deno Deploy has a restriction that does not allow to generate preview deployment on external PR when using environment variables. This is to prevent environment variable theft.

I think it's inconvenient to not be able to use Preview when there are many PRs from outside, like in this repository.
We may want to wait to introduce it until we really need it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants