Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump minimum Deno version to 1.41.1 #309

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

chore: bump minimum Deno version to 1.41.1 #309

wants to merge 4 commits into from
+37 −28

Conversation

magurotuna
Copy link
Member

This commit bumps the minimum required Deno version to 1.41.1 since in fact this is the real minimum version required to actually use the current deployctl. The following error log will appear if we try to run deployctl using Deno 1.41.0:

# deno --version
deno 1.41.0 (release, aarch64-unknown-linux-gnu)
v8 12.1.285.27
typescript 5.3.3
# deno install -Arf jsr:@deno/deployctl
✅ Successfully installed deployctl
/root/.deno/bin/deployctl
# deployctl
A new release of Deno is available: 1.41.0 → 1.42.4 Run `deno upgrade` to install it.
error: Uncaught (in promise) TypeError: Importing a JSR package via an HTTPS URL is not implemented. Use a jsr: specifier instead for the time being.
  const fs = await import("./token_storage/fs.ts");
             ^
    at async https://jsr.io/@deno/deployctl/1.12.0/src/utils/token_storage.ts:33:14

Upgrading Deno to 1.41.1 solves this issue.

Also, this commit adds a clear statement to readme that 1.41.1+ is required to use deployctl. This should help new users trying to use deployctl to some extent, because it's very hard to figure out what they need to do to solve the issue from the error message they run into when their Deno version is old.

Closes #308

@magurotuna magurotuna mentioned this pull request Apr 26, 2024
Open
@magurotuna magurotuna mentioned this pull request Apr 26, 2024
Open
1 task
arnauorriols
arnauorriols approved these changes Apr 26, 2024
View reviewed changes
Copy link
Member

@arnauorriols arnauorriols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'd like some clarification on why we need to use type-only imports.

deployctl.ts Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnauorriols arnauorriols arnauorriols approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DNS error when trying to install @deno/deployctl
2 participants
@magurotuna @arnauorriols