{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":551536076,"defaultBranch":"main","name":"node","ownerLogin":"deokjinkim","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2022-10-14T15:32:06.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/5592478?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1717857946.0","currentOid":""},"activityList":{"items":[{"before":"309febd5f3b0b30c412a3ee9790903aea2dd1ed8","after":"0883a7e061844e58e53d5d59317ba56cb0d5f473","ref":"refs/heads/240608_fix_naming_convention_of_symbol","pushedAt":"2024-06-09T00:00:14.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"deokjinkim","name":"Deokjin Kim","path":"/deokjinkim","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5592478?s=80&v=4"},"commit":{"message":"Update lib/internal/event_target.js\n\nCo-authored-by: Luigi Pinca <luigipinca@gmail.com>","shortMessageHtmlLink":"Update lib/internal/event_target.js"}},{"before":null,"after":"309febd5f3b0b30c412a3ee9790903aea2dd1ed8","ref":"refs/heads/240608_fix_naming_convention_of_symbol","pushedAt":"2024-06-08T14:45:46.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"deokjinkim","name":"Deokjin Kim","path":"/deokjinkim","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5592478?s=80&v=4"},"commit":{"message":"lib: fix naming convention of `Symbol`\n\n`node.js` prefix is used for global symbol(`Symbol.for`).\nSo remove `node.js` prefix from `Symbol` usage.\n\nRefs: https://github.com/nodejs/node/blob/main/doc/contributing/using-symbols.md#symbolforstring","shortMessageHtmlLink":"lib: fix naming convention of <code>Symbol</code>"}},{"before":"104459011ab5b093f946cfb71b5b0334ac4a833d","after":"1f4e73cbffb55dfa97b867a13aa8da123e06c6db","ref":"refs/heads/240526_refactor_to_use_minmax_validateInteger","pushedAt":"2024-05-29T13:16:58.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"deokjinkim","name":"Deokjin Kim","path":"/deokjinkim","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5592478?s=80&v=4"},"commit":{"message":"test_runner: refactor to use min/max of `validateInteger`\n\nInstead of additional `if` statement, use min/max of\n`validateInteger` for `shard.index`.","shortMessageHtmlLink":"test_runner: refactor to use min/max of <code>validateInteger</code>"}},{"before":"91c4c7b9463a87288baabe1929a886b0416def1d","after":"104459011ab5b093f946cfb71b5b0334ac4a833d","ref":"refs/heads/240526_refactor_to_use_minmax_validateInteger","pushedAt":"2024-05-28T14:07:16.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"deokjinkim","name":"Deokjin Kim","path":"/deokjinkim","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5592478?s=80&v=4"},"commit":{"message":"test_runner: refactor to use min/max of `validateInteger`\n\nInstead of additional `if` statement, use min/max of\n`validateInteger` for `shard.index`.","shortMessageHtmlLink":"test_runner: refactor to use min/max of <code>validateInteger</code>"}},{"before":"96c85c05a7da242a5eaf0fc259488d530020bddc","after":"91c4c7b9463a87288baabe1929a886b0416def1d","ref":"refs/heads/240526_refactor_to_use_minmax_validateInteger","pushedAt":"2024-05-25T15:19:09.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"deokjinkim","name":"Deokjin Kim","path":"/deokjinkim","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5592478?s=80&v=4"},"commit":{"message":"test_runner: refactor to use min/max of `validateInteger`\n\nInstead of additional `if` statement, use min/max of\n`validateInteger` for `shard.index`.","shortMessageHtmlLink":"test_runner: refactor to use min/max of <code>validateInteger</code>"}},{"before":"27e689b9719cf6761093d47aca80a28affc3dc4c","after":"96c85c05a7da242a5eaf0fc259488d530020bddc","ref":"refs/heads/240526_refactor_to_use_minmax_validateInteger","pushedAt":"2024-05-25T15:13:50.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"deokjinkim","name":"Deokjin Kim","path":"/deokjinkim","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5592478?s=80&v=4"},"commit":{"message":"test_runner: refactor to use min/max of `validateInteger`\n\nInstead of additional `if` statement, use min/max of\n`validateInteger` for `shard.index`.","shortMessageHtmlLink":"test_runner: refactor to use min/max of <code>validateInteger</code>"}},{"before":null,"after":"27e689b9719cf6761093d47aca80a28affc3dc4c","ref":"refs/heads/240526_refactor_to_use_minmax_validateInteger","pushedAt":"2024-05-25T15:08:58.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"deokjinkim","name":"Deokjin Kim","path":"/deokjinkim","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5592478?s=80&v=4"},"commit":{"message":"test_runner: refactor to use min/max of `validateInteger`\n\nInstead of additional `if` statement, use min/max of\n`validateInteger` for `shard.index`.","shortMessageHtmlLink":"test_runner: refactor to use min/max of <code>validateInteger</code>"}},{"before":null,"after":"1a96b498980559dc71c76722238f683a673889d9","ref":"refs/heads/240525_fix_wrong_variable_name","pushedAt":"2024-05-25T14:17:52.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"deokjinkim","name":"Deokjin Kim","path":"/deokjinkim","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5592478?s=80&v=4"},"commit":{"message":"doc: fix wrong variable name in example of `timers.tick()`\n\nChange variable name from `twoSeconds` to `threeSeconds` because\nactual value is 3000(ms). And add missing supported timer\nvalue(clearImmediate). Plus, fix typo(implicity -> implicitly).","shortMessageHtmlLink":"doc: fix wrong variable name in example of <code>timers.tick()</code>"}},{"before":"ec329739958cc58283df075311dc1b8a4d402800","after":"8975fef966be0cc29f03269bfc87a06bd5a979dd","ref":"refs/heads/240524_fix_wrong_function_name","pushedAt":"2024-05-24T14:54:52.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"deokjinkim","name":"Deokjin Kim","path":"/deokjinkim","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5592478?s=80&v=4"},"commit":{"message":"doc: fix wrong function name in example of `context.plan()`\n\nt.subtest -> t.test\n\nRefs: https://github.com/nodejs/node/pull/52860","shortMessageHtmlLink":"doc: fix wrong function name in example of <code>context.plan()</code>"}},{"before":null,"after":"ec329739958cc58283df075311dc1b8a4d402800","ref":"refs/heads/240524_fix_wrong_function_name","pushedAt":"2024-05-24T14:54:02.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"deokjinkim","name":"Deokjin Kim","path":"/deokjinkim","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5592478?s=80&v=4"},"commit":{"message":"doc: fix wrong function name in example of `context.plan()`\n\nt.subtest -> t.test","shortMessageHtmlLink":"doc: fix wrong function name in example of <code>context.plan()</code>"}},{"before":"06a1e934fff9f0c127452d9a96125b91a4625b07","after":"075f92479a830122b5c0db53d2ac8f6715b330e7","ref":"refs/heads/240515_remove_unavailable_youtube_link","pushedAt":"2024-05-14T15:33:38.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"deokjinkim","name":"Deokjin Kim","path":"/deokjinkim","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5592478?s=80&v=4"},"commit":{"message":"doc: remove unavailable youtube link in pull requests\n\nThis video(https://www.youtube.com/watch?v=HW0RPaJqm4g) isn't\navailable anymore. And I couldn't find a proper github code\nreview tutorial clip yet.","shortMessageHtmlLink":"doc: remove unavailable youtube link in pull requests"}},{"before":null,"after":"06a1e934fff9f0c127452d9a96125b91a4625b07","ref":"refs/heads/240515_remove_unavailable_youtube_link","pushedAt":"2024-05-14T15:31:01.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"deokjinkim","name":"Deokjin Kim","path":"/deokjinkim","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5592478?s=80&v=4"},"commit":{"message":"doc: remove unavailable youtube link in pull requests\n\nThis video isn't available anymore. And I couldn't find\na proper github code review tutorial clip yet.","shortMessageHtmlLink":"doc: remove unavailable youtube link in pull requests"}},{"before":"40e1c33739dbf13cc29bf075043a697ce555a7a3","after":"aa15c0cf0dc568d8713e8bdd2febfef80d933dcc","ref":"refs/heads/230907_revise_mock_timers","pushedAt":"2024-05-14T04:06:50.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"deokjinkim","name":"Deokjin Kim","path":"/deokjinkim","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5592478?s=80&v=4"},"commit":{"message":"test_runner: use validateStringArray for `timers.enable()`\n\n`apis` which is argument of `timers.enable()` is string array.\nSo use `validatStringArray` instead of `validateArray`. And\n`options` is optional, so update JSDoc.","shortMessageHtmlLink":"test_runner: use validateStringArray for <code>timers.enable()</code>"}},{"before":null,"after":"1cec1dd0ba9504c565c0878b707700c9c95f497a","ref":"refs/heads/240514_add_missing_supported_timer_values_in_timers","pushedAt":"2024-05-13T15:56:06.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"deokjinkim","name":"Deokjin Kim","path":"/deokjinkim","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5592478?s=80&v=4"},"commit":{"message":"doc: add missing supported timer values in `timers.enable()`\n\nSome timer values such as `setImmediate` and `clearImmediate` are\nmissed. And `milliseconds` which is argument of `timers.tick()`\nis optional and default is 1.\n\nRefs: https://github.com/nodejs/node/pull/49534#discussion_r1597457356","shortMessageHtmlLink":"doc: add missing supported timer values in <code>timers.enable()</code>"}},{"before":null,"after":"d9f9f5228a9d255dbd70da75d145af7821dac47c","ref":"refs/heads/240419_use_predefined_variable","pushedAt":"2024-04-18T16:11:52.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"deokjinkim","name":"Deokjin Kim","path":"/deokjinkim","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5592478?s=80&v=4"},"commit":{"message":"lib: use predefined variable instead of bit operation","shortMessageHtmlLink":"lib: use predefined variable instead of bit operation"}},{"before":null,"after":"316c57d8f91c0f6633916b237e5c8cd3ee421561","ref":"refs/heads/240301_fix_example_in_events","pushedAt":"2024-02-29T15:27:23.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"deokjinkim","name":"Deokjin Kim","path":"/deokjinkim","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5592478?s=80&v=4"},"commit":{"message":"doc: fix actual result of example is different in events\n\nRefs: https://github.com/nodejs/node/pull/50428","shortMessageHtmlLink":"doc: fix actual result of example is different in events"}},{"before":"ba15590e441e37c7c0c6cb9f38c7d29a3d3133af","after":"40e1c33739dbf13cc29bf075043a697ce555a7a3","ref":"refs/heads/230907_revise_mock_timers","pushedAt":"2024-01-29T14:16:01.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"deokjinkim","name":"Deokjin Kim","path":"/deokjinkim","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5592478?s=80&v=4"},"commit":{"message":"test_runner: use validateStringArray for `timers.enable()`\n\n`apis` which is argument of `timers.enable()` is string array.\nSo use `validatStringArray` instead of `validateArray`. And\n`options` is optional, so update JSDoc.\nIn document, some default value of `timers` are missed such as\n`setImmediate` and `clearImmediate`. Next, `milliseconds` which\nis argument of `timers.tick() is optional and default is 1.","shortMessageHtmlLink":"test_runner: use validateStringArray for <code>timers.enable()</code>"}},{"before":"e60e981ad8bfe8e77f33700adf8fdcf4311f4505","after":"ba15590e441e37c7c0c6cb9f38c7d29a3d3133af","ref":"refs/heads/230907_revise_mock_timers","pushedAt":"2024-01-29T14:12:36.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"deokjinkim","name":"Deokjin Kim","path":"/deokjinkim","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5592478?s=80&v=4"},"commit":{"message":"test_runner: use validateStringArray for `timers.enable()`\n\n`apis` which is argument of `timers.enable()` is string array.\nSo use `validatStringArray` instead of `validateArray`. And\n`options` is optional, so update JSDoc.\nIn document, some default value of `timers` are missed such as\n`setImmediate` and `clearImmediate`. Next, `milliseconds` which\nis argument of `timers.tick() is optional and default is 1.","shortMessageHtmlLink":"test_runner: use validateStringArray for <code>timers.enable()</code>"}},{"before":null,"after":"9ac2062c34310ab5dc2ea0b9f50fc5139232ce7e","ref":"refs/heads/231128_refactor_to_use_validatefunction","pushedAt":"2023-11-28T13:44:35.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"deokjinkim","name":"Deokjin Kim","path":"/deokjinkim","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5592478?s=80&v=4"},"commit":{"message":"lib: refactor to use validateFunction in diagnostics_channel\n\nUse validateFunction to remove duplicate implementation.","shortMessageHtmlLink":"lib: refactor to use validateFunction in diagnostics_channel"}},{"before":"f3a3ec61a924f7aabecc64e7ea90831fe07c9347","after":"1e5ba2d02303b12c71ccab9afce83acb9d30bfa3","ref":"refs/heads/231114_add_min_to_read","pushedAt":"2023-11-14T03:48:17.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"deokjinkim","name":"Deokjin Kim","path":"/deokjinkim","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5592478?s=80&v=4"},"commit":{"message":"streams: add min option to read()","shortMessageHtmlLink":"streams: add min option to read()"}},{"before":null,"after":"f3a3ec61a924f7aabecc64e7ea90831fe07c9347","ref":"refs/heads/231114_add_min_to_read","pushedAt":"2023-11-13T22:58:16.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"deokjinkim","name":"Deokjin Kim","path":"/deokjinkim","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5592478?s=80&v=4"},"commit":{"message":"stream: add min option to read()","shortMessageHtmlLink":"stream: add min option to read()"}},{"before":"76acb0490a993a0c99189bdd6275672c3ecb3372","after":"68ce7f9ecb8f459737b7faf134f542f8235c29be","ref":"refs/heads/231110_handle_error_connect2","pushedAt":"2023-11-10T14:43:29.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"deokjinkim","name":"Deokjin Kim","path":"/deokjinkim","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5592478?s=80&v=4"},"commit":{"message":"src: handle errors from uv_pipe_connect2()\n\nWe need to handle errors from uv_pipe_connect2()\nbecause return type is `int`.\n\nFixes: https://github.com/nodejs/node/issues/50652\nRefs: https://github.com/nodejs/node/pull/49667\nRefs: https://github.com/libuv/libuv/pull/4030","shortMessageHtmlLink":"src: handle errors from uv_pipe_connect2()"}},{"before":null,"after":"76acb0490a993a0c99189bdd6275672c3ecb3372","ref":"refs/heads/231110_handle_error_connect2","pushedAt":"2023-11-10T14:43:05.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"deokjinkim","name":"Deokjin Kim","path":"/deokjinkim","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5592478?s=80&v=4"},"commit":{"message":"src: handle errors from uv_pipe_connect2()\n\nWe need to handle errors from uv_pipe_connect2()\nbecause return type is `int`.\n\nFixes: https://github.com/nodejs/node/issues/50652\nRefs: https://github.com/nodejs/node/pull/49667\nRefs: https://github.com/libuv/libuv/pull/4030","shortMessageHtmlLink":"src: handle errors from uv_pipe_connect2()"}},{"before":null,"after":"245cd8c7bf7c19c220773080feeb471d78d5b3fc","ref":"refs/heads/231106_add_missing_description_argument","pushedAt":"2023-11-06T14:30:19.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"deokjinkim","name":"Deokjin Kim","path":"/deokjinkim","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5592478?s=80&v=4"},"commit":{"message":"doc: add missing description of argument in `subtle.encrypt`\n\nDescription of third argument(data) in subtle.encrypt is missed,\nso add it.","shortMessageHtmlLink":"doc: add missing description of argument in <code>subtle.encrypt</code>"}},{"before":null,"after":"e7b5c99edab58c5c09d08f54ee647076c2559f55","ref":"refs/heads/231106_fix_argument_mime","pushedAt":"2023-11-06T13:34:10.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"deokjinkim","name":"Deokjin Kim","path":"/deokjinkim","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5592478?s=80&v=4"},"commit":{"message":"util: fix wrong argument of `ERR_INVALID_MIME_SYNTAX`\n\nThird argument of ERR_INVALID_MIME_SYNTAX is invalid index\n(not string).","shortMessageHtmlLink":"util: fix wrong argument of <code>ERR_INVALID_MIME_SYNTAX</code>"}},{"before":"f8d52dea6d40f1342962a5ad0c4ab5a37a239130","after":"603d345962b49d34696b5a47717e2417797defa5","ref":"refs/heads/231103_tls_snicallback","pushedAt":"2023-11-02T16:49:24.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"deokjinkim","name":"Deokjin Kim","path":"/deokjinkim","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5592478?s=80&v=4"},"commit":{"message":"tls: use `validateFunction` for `options.SNICallback`\n\nIf user uses invalid type for `options.SNICallback` in\nTLSSocket(), it's not internal issue of Node.js. So\nvalidateFunction() is more proper than assert().","shortMessageHtmlLink":"tls: use <code>validateFunction</code> for <code>options.SNICallback</code>"}},{"before":null,"after":"f8d52dea6d40f1342962a5ad0c4ab5a37a239130","ref":"refs/heads/231103_tls_snicallback","pushedAt":"2023-11-02T16:39:14.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"deokjinkim","name":"Deokjin Kim","path":"/deokjinkim","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5592478?s=80&v=4"},"commit":{"message":"tls: use `validateFunction` for `options.SNICallback`\n\nIf user uses invalid type for `options.SNICallback` in\nTLSSocket(), it's not internal issue of Node.js. So\nvalidateFunction() is more proper than assert().","shortMessageHtmlLink":"tls: use <code>validateFunction</code> for <code>options.SNICallback</code>"}},{"before":"db90127279f944bdc61288ab3afa336af562d26b","after":"4e0e6e4e48c16691535432eb9cabf495729094fe","ref":"refs/heads/230930_use_validateNumber_for_minDHSize","pushedAt":"2023-10-01T11:22:18.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"deokjinkim","name":"Deokjin Kim","path":"/deokjinkim","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5592478?s=80&v=4"},"commit":{"message":"tls: use `validateNumber` for `options.minDHSize`\n\nIf user sets invalid type for options.minDHSize in\ntls.connect(), it's not internal issue of Node.js. So\nvalidateNumber() is more proper than assert(). Plus,\nset min of validateNumber() as 1 to check minDHSize\nis positive.\n\nRefs: https://github.com/nodejs/node/pull/49896","shortMessageHtmlLink":"tls: use <code>validateNumber</code> for <code>options.minDHSize</code>"}},{"before":"6769e6986e6bf839559fd9bdd560e707158f159c","after":"db90127279f944bdc61288ab3afa336af562d26b","ref":"refs/heads/230930_use_validateNumber_for_minDHSize","pushedAt":"2023-09-30T03:24:17.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"deokjinkim","name":"Deokjin Kim","path":"/deokjinkim","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5592478?s=80&v=4"},"commit":{"message":"tls: use `validateNumber` for `options.minDHSize`\n\nIf user sets invalid type for options.minDHSize in\ntls.connect(), it's not internal issue of Node.js. So\nvalidateNumber() is more proper than assert(). Plus,\nset min of validateNumber() as 1 to check minDHSize\nis positive.\n\nRefs: https://github.com/nodejs/node/pull/49896","shortMessageHtmlLink":"tls: use <code>validateNumber</code> for <code>options.minDHSize</code>"}},{"before":null,"after":"6769e6986e6bf839559fd9bdd560e707158f159c","ref":"refs/heads/230930_use_validateNumber_for_minDHSize","pushedAt":"2023-09-30T03:15:52.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"deokjinkim","name":"Deokjin Kim","path":"/deokjinkim","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5592478?s=80&v=4"},"commit":{"message":"tls: use `validateNumber` for `options.minDHSize`\n\nIf user sets invalid type for options.minDHSize in\ntls.connect(), it's not internal issue of Node.js. So\nvalidateNumber() is more proper than assert(). Plus,\nset min of validateNumber() as 1 to check minDHSize\nis positive.\n\nRefs: https://github.com/nodejs/node/pull/49896","shortMessageHtmlLink":"tls: use <code>validateNumber</code> for <code>options.minDHSize</code>"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEYCIVkQA","startCursor":null,"endCursor":null}},"title":"Activity · deokjinkim/node"}