Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File Input - Update v3 component to align with Figma #2642

Closed
3 tasks
Assignees
Labels
dst-engineering Issues that require work from Design System Team engineers pattern-files Ask users for files platform-design-system-team va-file-input

Comments

@micahchiang
Copy link
Contributor

Description

After 2641 is complete, V3 file input needs to be updated to align with designs in Figma. Specifically, it needs to include: Change File button, delete button, and cancel upload button. It also needs an upload progress bar. Finally, it needs to be updated to include a slot that can be filled with a select input, text input or something else to convey additional information about the file.

Screenshots

Icon Buttons for file input Screenshot from 2024-03-29 12-18-15.png
Additional information file input image.png

Tasks

  • Add buttons and progress bar to file input
  • Add additional information slot

Acceptance Criteria

  • Above tasks have been completed
@caw310
Copy link
Contributor

caw310 commented Mar 29, 2024

@nickjg231
Copy link
Contributor

Carrying over to next sprint so we can move away from USWDS's usa-file-input logic and move it all into component-library

@caw310
Copy link
Contributor

caw310 commented Apr 24, 2024

Work on this was also impacted by sick leave.

@nickjg231
Copy link
Contributor

A first draft of this is finished but there are additional questions we as a team need to discuss, so this will carry over. Some of these questions include:

  1. Should we find a way to handle the progress bar, or look into whether users can use the slot to implement their own
  2. When should we truncate the file name for long files
  3. The math for the file size is calculating a slightly smaller value than the file system's file size
  4. Should we use the file logic that already exists for displaying previews of files users are uploading

@harshil1793 harshil1793 self-assigned this May 9, 2024
@harshil1793 harshil1793 removed their assignment May 16, 2024
@nickjg231
Copy link
Contributor

Ticket is done but waiting approval from Matt. If approved, it can be merged. Otherwise, it'll carry over.

@humancompanion-usds
Copy link
Collaborator

@nickjg231 - Where can I see the component in order to review it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dst-engineering Issues that require work from Design System Team engineers pattern-files Ask users for files platform-design-system-team va-file-input
Projects
None yet
5 participants