Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt spotlight-card class on spotlight cards on Vet Centers and VBA #18126

Closed
3 tasks
laflannery opened this issue May 15, 2024 · 6 comments
Closed
3 tasks
Assignees
Labels
Facilities Facilities products (VAMC, Vet Center, etc) Regional office CMS managed VBA product owned by the Facilities team Unplanned work Work that was introduced post-planning VA.gov frontend CMS team practice area Vet Center CMS managed product owned by Facilities team

Comments

@laflannery
Copy link
Contributor

laflannery commented May 15, 2024

Description

An editor add a naked link into one of their spotlights. Because these do not wrap natively, the spotlights did not keep their equal widths and instead one became much larger than the others to accommodate the nakedness. This happened on Greensboro Vet Center and looked like:

Screenshot 2024-05-15 at 11 39 47 AM

Both Eli and Josh reviewed. We originally thought that we would want to update these to use a grid layout. However, Josh added a new class to handled this - see original comment. This has already been done to VAMCs on prod and can be seen here.

We would like to add the spotlight-card class to the card components on both Vet centers and VBA spotlights.

Acceptance Criteria

  • spotlight-card class has been added to Vet Center spotlights so that now they always display properly and have equal widths when there are 2 or 3 added
  • spotlight-card class has been added to VBA spotlights always so that now they display properly and have equal widths when there are 2 or 3 added (here or separate ticket)
  • Requires design review
@laflannery laflannery added Needs refining Issue status VA.gov frontend CMS team practice area Facilities Facilities products (VAMC, Vet Center, etc) labels May 15, 2024
@aklausmeier
Copy link

I have also inquired about naked link error validation in Drupal in Slack.

@eselkin
Copy link
Contributor

eselkin commented May 16, 2024

This happens on non-naked-links too here, like email addresses (separated not with spaces but   from that preferred)

Screenshot 2024-05-15 at 6 18 46 PM

@eselkin
Copy link
Contributor

eselkin commented May 16, 2024

Actually found the style="word-break: break-word;" does wrap the naked links. So we don't need to switch to the grid. We can keep the flex.

@aklausmeier
Copy link

@eselkin Does the wrap solution keep the 3 columns to equal widths?

@jtmst
Copy link

jtmst commented May 20, 2024

by adding the following class we will be able to maintain equal width and appropriately wrap long links:

.spotlight-card { min-width: 30%; word-wrap: break-word; }

I'll be adding this as part of the health-services PR component migration PR, we will just need to add the class to other instances of the cards if @eselkin agrees that this works

@davidmpickett davidmpickett added Vet Center CMS managed product owned by Facilities team Regional office CMS managed VBA product owned by the Facilities team and removed Needs refining Issue status labels May 23, 2024
@laflannery laflannery changed the title Update Spotlights to use grid layout Adopt spotlight-card class on spotlight cards on Vet Centers and VBA May 23, 2024
@eselkin eselkin self-assigned this May 23, 2024
@jilladams jilladams added the Unplanned work Work that was introduced post-planning label May 24, 2024
@davidmpickett
Copy link
Contributor

Verified on Prod for Vet Center
Screenshot 2024-05-28 at 6 03 33 PM

Verified on Preview for VBA
Screenshot 2024-05-28 at 6 05 41 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Facilities Facilities products (VAMC, Vet Center, etc) Regional office CMS managed VBA product owned by the Facilities team Unplanned work Work that was introduced post-planning VA.gov frontend CMS team practice area Vet Center CMS managed product owned by Facilities team
Projects
None yet
Development

No branches or pull requests

6 participants