Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VBA: audit for V1 facilities-api calls #18127

Closed
2 tasks done
jilladams opened this issue May 15, 2024 · 2 comments
Closed
2 tasks done

VBA: audit for V1 facilities-api calls #18127

jilladams opened this issue May 15, 2024 · 2 comments
Assignees
@eselkin
Labels
Facilities Facilities products (VAMC, Vet Center, etc) Regional office CMS managed VBA product owned by the Facilities team VA.gov frontend CMS team practice area

Comments

@jilladams
Copy link
Contributor

jilladams commented May 15, 2024 •
edited by eselkin

Scan VBA product templates to verify that we are making no direct API calls, and all data returned is via Drupal / GraphQL.

ACs

  • Any facilities-api calls are using V2
  • No regressions to product behavior
@jilladams jilladams added Needs refining Issue status VA.gov frontend CMS team practice area Facilities Facilities products (VAMC, Vet Center, etc) Regional office CMS managed VBA product owned by the Facilities team and removed Needs refining Issue status labels May 15, 2024
@eselkin
Copy link
Contributor

eselkin commented May 24, 2024 •
edited

I had audited and changed in my PR department-of-veterans-affairs/vets-website#29890
This changed VBA (tested locally), Vet Center Locations and facilities (where /va was used), and VAMC locations and facilities (where /va was used)

@jilladams
Copy link
Contributor Author

THis was shipped, and rolled back. Rolling forward will be tracked under #18237 . Closing.

@jilladams jilladams mentioned this issue May 29, 2024
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eselkin eselkin

Labels
Facilities Facilities products (VAMC, Vet Center, etc) Regional office CMS managed VBA product owned by the Facilities team VA.gov frontend CMS team practice area
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eselkin @jilladams