Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In Service Locations, Phone number type should be honored within the component #18131

Closed
4 tasks
laflannery opened this issue May 16, 2024 · 2 comments
Closed
4 tasks
Assignees
Labels
accessibility Issues related to accessibility Facilities Facilities products (VAMC, Vet Center, etc) Unplanned work Work that was introduced post-planning VA.gov frontend CMS team practice area VAMC CMS managed product owned by Facilities team

Comments

@laflannery
Copy link
Contributor

laflannery commented May 16, 2024

Description

When an editor chooses a type of phone that isn't phone, specific props should be used for the FE display:

  • If a phone number is type SMS it uses the sms prop
  • If a phone number is type Fax it uses the not-clickable prop and does NOT use the message-aria-describedby prop
  • If a phone number is type TTY it uses the tty prop

We had done this in the Phone component ticket however, after Service Locations launched, this seems to have reverted. Examples:

  • Fax numbers that are type Fax but are not using the correct component props:
  • TTY and SMS are rarely if ever used so I don't have examples of those but I would think this logic has been reverted just because we did it at the same time

This needs to be done in:

  • VAMC Facility Health Services
  • VAMC Non-clinical Services
  • VBA Facility Services

Acceptance Criteria

  • Phone numbers that are type SMS use the sms prop
  • Phone numbers that are type Fax use the not-clickable prop and do NOT use the message-aria-describedby prop
  • Phone numbers that are type TTY use the tty prop
  • Requires accessibility review
@laflannery laflannery added Needs refining Issue status Facilities Facilities products (VAMC, Vet Center, etc) VAMC CMS managed product owned by Facilities team VA.gov frontend CMS team practice area accessibility Issues related to accessibility labels May 16, 2024
@jilladams jilladams removed the Needs refining Issue status label May 22, 2024
@eselkin eselkin self-assigned this May 22, 2024
@davidmpickett
Copy link
Contributor

@jilladams I added this to sprint 4 since it was injected

@laflannery
Copy link
Contributor Author

Confirmed on prod!
image

@jilladams jilladams added the Unplanned work Work that was introduced post-planning label May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Issues related to accessibility Facilities Facilities products (VAMC, Vet Center, etc) Unplanned work Work that was introduced post-planning VA.gov frontend CMS team practice area VAMC CMS managed product owned by Facilities team
Projects
None yet
Development

No branches or pull requests

4 participants