Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

12x more useful if Missing dependencies includes the file it was found it #428

Closed
twk-b opened this issue Oct 17, 2019 · 3 comments · Fixed by #433
Closed

12x more useful if Missing dependencies includes the file it was found it #428

twk-b opened this issue Oct 17, 2019 · 3 comments · Fixed by #433

Comments

@twk-b
Copy link

twk-b commented Oct 17, 2019

Feature request description

i have a list of Missing dependencies, and i want to know what should be investigated, excluded, or otherwise

Expected output

$ depcheck
Missing dependencies
fred: ./src/yourfile.js line 4
james: ./dist/whocars.js line 29,999

Any extra info

pure awesome

@LinusU
Copy link
Member

LinusU commented Oct 17, 2019

That would be nice 👍

@rumpl
Copy link
Member

rumpl commented Oct 28, 2019

@twk-b Wanna do it? It sure could be 12x (at least) more useful!

@twk-b
Copy link
Author

twk-b commented Oct 29, 2019

428.diff.txt

  • doesnt have line counts
  • syntax loads in VScode to load correct file
  • shows relative path
  • all tests still passing

rumpl added a commit that referenced this issue Oct 29, 2019
Closes #428

Co-authored-by: Bernie @twk-b
rumpl added a commit that referenced this issue Oct 29, 2019
Closes #428

Co-authored-by: Bernie @twk-b
rumpl added a commit that referenced this issue Oct 31, 2019
* Add paths for missing dependencies

Closes #428

Co-authored-by: Bernie @twk-b

* Add test for missing dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants