Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

special/webpack: babel-loader presets are not detected #448

Closed
sveyret opened this issue Nov 1, 2019 · 1 comment
Closed

special/webpack: babel-loader presets are not detected #448

sveyret opened this issue Nov 1, 2019 · 1 comment

Comments

@sveyret
Copy link
Contributor

sveyret commented Nov 1, 2019

Bug Description

When a babel preset is used in webpack configuration file, it is not detected as a dependency.

Code snippets

Where the dependency is used:

module.export = {
    module: {
      rules: [
        {
          test: /\.js$/, use: {
            loader: 'babel-loader',
            options: { presets: [
              ['@babel/preset1', { option: 'option' }],
              '@babel/preset2'
            ]},
          }
        },
      ],
    },
}

Where the dependency is listed in package.json:

"devDependencies": {
  "@babel/preset1": "7.6.3",
  "@babel/preset2": "7.6.3",
}

Versions

  • node -v: v8.12.0
  • npm -v: 6.4.1
  • depcheck --version: 0.8.4

Extra info

Currently creating a PR for that.

rumpl pushed a commit that referenced this issue Nov 1, 2019
* special/webpack: Manage TypeScript webpack definition

Issue #246

* special/webpack: Scan webpack entries for dependencies

Issue #446

* special/webpack: Detect babel-loader presets

Issue #448
@rumpl
Copy link
Member

rumpl commented Nov 1, 2019

Closed with #449

@rumpl rumpl closed this as completed Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants