Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False Alert when including dependency for its types #582

Closed
Freddixx opened this issue Sep 30, 2020 · 5 comments
Closed

False Alert when including dependency for its types #582

Freddixx opened this issue Sep 30, 2020 · 5 comments
Labels

Comments

@Freddixx
Copy link

Hi 👋 ,

I am working on a project where I had to add three packages just for the sake of using their typescript types (which is the officially recommended way as of the time I am writing this). I know it's not a good practice, but there is no way around it for now.

The problem is that depcheck is obviously failing because of these unused dependencies and my gut is telling me there is no way of telling those apart. The upside is that the packages are only really required during dev-time since they are types. Hence, is there any way to exclude devDependencies from the check altogether?

Maybe I didn't check the readme throughly enough, but it would be great if that feature existed.

Thanks!

@Freddixx Freddixx changed the title False Alert when including dependencies for its types False Alert when including dependency for its types Oct 1, 2020
@rumpl
Copy link
Member

rumpl commented Nov 8, 2020

@Freddixx there was such a flag but it was removed

We should really have better support for typescript...

@Freddixx
Copy link
Author

Freddixx commented Nov 8, 2020

Just my luck then 🤷‍♂️ 😃

Any chance that this could be brought back?

@rumpl
Copy link
Member

rumpl commented Nov 8, 2020

Adding proper TS support is something I wanted to do for a long time, just never managed to gather the courage and the motivation, I hope I'll get to it one day. Sorry, I can't promise anything

@Freddixx
Copy link
Author

I see.

I didn't see that PR you mentioned linked to any issue but this one, so I don't know enough about the history why this got removed in the first place. But I guess you don't see any point in bringing it back, no?

@stale
Copy link

stale bot commented Mar 16, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Mar 16, 2021
@stale stale bot closed this as completed Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants