Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release pipeline #845

Open
rumpl opened this issue Oct 17, 2023 · 3 comments
Open

Release pipeline #845

rumpl opened this issue Oct 17, 2023 · 3 comments
Labels

Comments

@rumpl
Copy link
Member

rumpl commented Oct 17, 2023

Feature request description

I would like us to change the release pipeline, currently, in order to make a new release I have to:

  • create a new tag
  • create a release for that tag in github
  • this will start a GHA that will release depcheck on npm

The issue with this order is that, after creating/pushing a tag the release GHA could fail (it has happened in the past). And we are now stuck with a tag that doesn't mean anything and was never released.

We should switch the pipeline so that I can do:

  • start a release pipeline by giving it a git ref (branch, commit, whatever), using main as default
  • once the release is really up on npm I can create a tag for it
  • after tagging I can create a release in github

I'm pretty sure there exists a GHA somewhere that could do all of this in a single setting so that I don't even have to create the tag/release myself.

@rumpl rumpl added the feature label Oct 17, 2023
@pastelsky
Copy link
Contributor

@rumpl have you considered using np — It takes away a lot of the pain with publishing new versions.

Also, it's been a while since an update was released. There's a bunch of fixes on master that I could use — do you mind cutting a release?

@rumpl
Copy link
Member Author

rumpl commented Feb 1, 2024

Of course sindresorhus made a package for that :D

I didn't know np existed, I'll take a look.

Yeah I think it's high time for a new release, I'll take a quick look at the pending PRs and make a new release 👍

@pastelsky
Copy link
Contributor

Thanks for your effort in maintaining this. Looking forward to the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants