Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always pull, even if image available locally #271

Open
JamieMagee opened this issue Feb 8, 2024 · 3 comments
Open

Always pull, even if image available locally #271

JamieMagee opened this issue Feb 8, 2024 · 3 comments

Comments

@JamieMagee
Copy link
Contributor

If we're using a mutable tag, like latest, we should always try and pull the container image regardless of whether or not it's available locally.

cli/internal/infra/run.go

Lines 470 to 473 in 35deb52

inspect, _, err := cli.ImageInspectWithRaw(ctx, image)
// pull image if necessary
if err != nil {

@jakecoffman
Copy link
Member

My workflow is I will run script/build which builds the latest image locally and then I can run dependabot, or make changes and run script/dependabot from there on out. I just need to build that initial image because I'm on an ARM machine and we don't currently build multiple architectures.

I'm open to changing the default behavior for a better user experience for users if we can also set it up to be a good experience for core developers too!

@JamieMagee
Copy link
Contributor Author

Let me open a draft PR to show you what I'm thinking.

@JamieMagee
Copy link
Contributor Author

See #272

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants