Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve mono-repository support #254

Open
mjpitz opened this issue Mar 19, 2021 · 0 comments
Open

Improve mono-repository support #254

mjpitz opened this issue Mar 19, 2021 · 0 comments
Labels
effort: 2 good first issue Good for newcomers. help state: approved Approved to proceed. type: fix Iterations on existing features or infrastructure. work: obvious The situation is obvious, best practices used.
Projects

Comments

@mjpitz
Copy link
Member

mjpitz commented Mar 19, 2021

In some cases, we assume the name of a library/application is the name of the repository in which the file resides. This works for many projects where you might use a repository per library or application but doesn't work as well for mono-repositories where files may be scattered across subdirectories. One simple way to handle this would be to pass along the file path in addition to the URL to the extraction logic.

The two cases that come to mind are:

  • requirements.txt - in this case, we probably want to assume the library name to be the name of the directory the file resides in
  • Gopkg.toml - in this case, it should be the inferred name (based on URL) plus the directory in the repo where it was found

Something nice about this issue is that the path is already available in the extractor process.. we simply need to update the internal interface and pass it through appropriately.

@mjpitz mjpitz added effort: 2 good first issue Good for newcomers. help state: approved Approved to proceed. type: fix Iterations on existing features or infrastructure. work: obvious The situation is obvious, best practices used. labels Mar 19, 2021
@mjpitz mjpitz added this to To Do in deps.cloud via automation Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: 2 good first issue Good for newcomers. help state: approved Approved to proceed. type: fix Iterations on existing features or infrastructure. work: obvious The situation is obvious, best practices used.
Projects
deps.cloud
  
To Do
Development

No branches or pull requests

1 participant