Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react): Add support for custom logger #181

Merged
merged 7 commits into from
Jun 16, 2021

Conversation

guidokessels
Copy link
Contributor

@guidokessels guidokessels commented Dec 15, 2020

At the moment @axe-core/react will always log the results to the console. We have a use case where we want to handle the results in a different way. To be able to do this I added a new optional parameter which can be used to handle the results from @axe-core/react. If this parameter is not defined it will fall back to logging to console.

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Code is reviewed for security

@dylanb
Copy link
Contributor

dylanb commented Dec 17, 2020

@jeeyyy LGTM but do we want to start adding more tests? If so, a test for this change would be good.

Copy link
Contributor

@jeeyyy jeeyyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guidokessels thanks for the PR ⭐
Could you add some tests please?

@jeeyyy
Copy link
Contributor

jeeyyy commented Jan 14, 2021

@guidokessels any updates on adding tests to these? I will ear mark this PR as WIP for now, please remove WIP from title once you have added the tests and updated the PR.

@jeeyyy jeeyyy changed the title Add support for custom logger [WIP] Add support for custom logger Jan 14, 2021
@stephenmathieson
Copy link
Member

stephenmathieson commented Jun 7, 2021

@dylanb IMO it's very unreasonable to ask contributors to add tests. The current test suite is extremely lacking and very confusing. Furthermore, it doesn't actually "work" (IIRC you can comment out axe.run() and the tests still pass). In order to add good tests, a contributor would first have to create a good test suite. This would be a considerable amount of work, and is not something I believe we can expect from drive-by-contributors.


Just tried to npm test in this package's directory. I got a "term-size" error from Cypress then it hung for a few minutes until I manually killed it. I have no idea how to fix this.

@stephenmathieson stephenmathieson requested a review from a team June 7, 2021 21:07
@stephenmathieson stephenmathieson changed the title [WIP] Add support for custom logger feat(react): Add support for custom logger Jun 7, 2021
Copy link
Member

@michael-siek michael-siek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much @guidokessels for your contribution!

@michael-siek michael-siek merged commit 1f97433 into dequelabs:develop Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants