fix: update axe-core to 4.2.1 #254
Conversation
packages/webdriverjs/package.json
Outdated
| }, | ||
| "peerDependencies": { | ||
| "selenium-webdriver": ">= 2.53.1" | ||
| "selenium-webdriver": "<= 4.0.0-beta.3 || >= 2.53.1" |
There was a problem hiding this comment.
Was this change intentional? Seems unrelated.
There was a problem hiding this comment.
This was intentional to remove the warning message since we use a prerelease version of selenium-webdriver.
There was a problem hiding this comment.
This might be a little wider than you want; I think the <= 4.0.0-beta.3 part would accept v1.0.0.
There was a problem hiding this comment.
(you can test this locally using the same library npm uses for semver matching with npx semver -r "<= 4.0.0-beta.3 || >= 2.53.1" "1.0.0" - it outputs 1.0.0, which indicates that it believes 1.0.0 matches the given range)
| @@ -41,7 +41,7 @@ | |||
| ], | |||
| "dependencies": { | |||
| "@axe-core/webdriverjs": "^4.2.0", | |||
| "axe-core": "^4.2.0", | |||
| "axe-core": "^4.2.1", | |||
There was a problem hiding this comment.
Just another reminder: users were able to use 4.2.1 before this patch landed. Since we have the ^ here, we'll allowing npm to install a range of versions, not exclusively 4.2.1 (previously 4.2.0).
michael-siek
changed the title
No description provided.