Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass chrome options to chromeOptions.addArguments() #262

Merged
merged 1 commit into from
Jun 3, 2021

Conversation

patsplat
Copy link
Contributor

@patsplat patsplat commented Jun 3, 2021

This PR should address #248

It updates 3 files to change how arguments are passed:

  • Removes a now unnecessary cast from packages/cli/src/types.ts
  • Changes how options are passed in packages/cli/src/lib/webdriver.ts
  • Modifies test for option passing to match new behavior in packages/cli/src/lib/webdriver.test.ts
  • Adds a test for multiple args in packages/cli/src/lib/webdriver.test.ts

@michael-siek michael-siek changed the title Use chromeOptions.addArguments() to pass args fix: pass chrome options to chromeOptions.addArguments() Jun 3, 2021
@michael-siek
Copy link
Member

michael-siek commented Jun 3, 2021

Thank you very much for your contribution @patsplat!
Reviewed for security

@michael-siek michael-siek merged commit 715f463 into dequelabs:develop Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants