Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(playwright): Make package public #264

Merged
merged 1 commit into from
Jun 7, 2021
Merged

fix(playwright): Make package public #264

merged 1 commit into from
Jun 7, 2021

Conversation

michael-siek
Copy link
Member

@michael-siek michael-siek commented Jun 7, 2021 •
edited

@michael-siek michael-siek requested a review from a team June 7, 2021 15:20
stephenmathieson
stephenmathieson approved these changes Jun 7, 2021
View reviewed changes
Copy link
Member

@stephenmathieson stephenmathieson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM but I don't think the commit message correctly describes it.

Maybe:

fix(playwright): Make package public

@michael-siek michael-siek changed the title chore(playwright): publish playwright to npmjs fix(playwright): Make package public Jun 7, 2021
@michael-siek michael-siek merged commit 35074ba into develop Jun 7, 2021
@michael-siek michael-siek deleted the michael-siek-patch-1 branch June 7, 2021 15:38
@michael-siek michael-siek mentioned this pull request Jun 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephenmathieson stephenmathieson stephenmathieson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@michael-siek @stephenmathieson