Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(webdriverio): return values using callback #346

Merged
merged 1 commit into from
Aug 31, 2021

Conversation

michael-siek
Copy link
Member

No description provided.

@michael-siek michael-siek requested a review from a team August 31, 2021 18:05
@stephenmathieson
Copy link
Member

What does this fix?

@michael-siek
Copy link
Member Author

@stephenmathieson
Copy link
Member

You should make the PR title/commit message indicative of that. See https://github.com/dequelabs/axe-api-team-proposals/blob/master/policies/commit-message-policy.md#subject

describes WHAT the commit does, not HOW it does it ("Align items horizontally" not "Set display=flex")

@michael-siek michael-siek changed the title fix(webdriverio): use executeAsync() vs execute() fix(webdriverio): return values using callback Aug 31, 2021
@michael-siek michael-siek changed the title fix(webdriverio): return values using callback chore(webdriverio): return values using callback Aug 31, 2021
@michael-siek michael-siek merged commit 0e4aa3a into develop Aug 31, 2021
@michael-siek michael-siek deleted the fix/webdriverio-executeasync branch August 31, 2021 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants