feat: Add .setLegacyMode #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilcoFiers
commented
Sep 8, 2021
michael-siek
requested changes
Sep 8, 2021
| * axe.finishRun() which is called in a blank page. This uses axe.run() instead, | ||
| * but with the restriction that cross-origin frames will not be tested. | ||
| */ | ||
| public setLegacyMode(legacyMode = true): this { |
There was a problem hiding this comment.
Suggested change
| public setLegacyMode(legacyMode = true): this { | |
| public setLegacyMode(legacyMode = true): AxeBuilder { |
There was a problem hiding this comment.
Should be this. If we extend this class (which we do in devtools), AxeBuilder is actually wrong.
| `; | ||
| ${this.source} | ||
| axe.configure({ | ||
| ${this.legacyMode ? '' : 'allowedOrigins: ["<unsafe_all_origins>"],'} |
There was a problem hiding this comment.
Suggested change
| ${this.legacyMode ? '' : 'allowedOrigins: ["<unsafe_all_origins>"],'} | |
| ${this.legacyMode ? ''allowedOrigins: ["<same_origin>"]' : 'allowedOrigins: ["<unsafe_all_origins>"],'} |
There was a problem hiding this comment.
That's exactly the same thing but with more characters. For what reason would you explicitly want to set it to the default?
michael-siek
approved these changes
Sep 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.