fix(webdriverjs): prevent selnium undefined -> null transformation #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
WilcoFiers
reviewed
Nov 19, 2021
packages/webdriverjs/src/browser.ts
Outdated
| @@ -49,7 +49,7 @@ export function axeRunPartial( | |||
| var callback = arguments[arguments.length - 1]; | |||
| var context = ${JSON.stringify(context)} || document; | |||
| var options = ${JSON.stringify(options)} || {}; | |||
| window.axe.runPartial(context, options).then(callback); | |||
| window.axe.runPartial(context, options).then(res => JSON.parse(JSON.stringify(res))).then(callback); | |||
There was a problem hiding this comment.
How does this solve the issue?
There was a problem hiding this comment.
The issue is that there are places where a key is set to undefined rather than deleting it. Selenium finds these and converts them to null. JSON roundtrip removed the keys
There was a problem hiding this comment.
Why not just return the string, so you don't have to serialise twice
WilcoFiers
previously requested changes
Nov 29, 2021
packages/webdriverjs/src/browser.ts
Outdated
| @@ -49,7 +49,7 @@ export function axeRunPartial( | |||
| var callback = arguments[arguments.length - 1]; | |||
| var context = ${JSON.stringify(context)} || document; | |||
| var options = ${JSON.stringify(options)} || {}; | |||
| window.axe.runPartial(context, options).then(callback); | |||
| window.axe.runPartial(context, options).then(res => JSON.parse(JSON.stringify(res))).then(callback); | |||
There was a problem hiding this comment.
Why not just return the string, so you don't have to serialise twice
AdnoC
dismissed
WilcoFiers’s stale review
Got rid of extra serialization. Added a test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.