Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webdriverJS): include/exclude chaining and iframe selectors #404

Merged
merged 4 commits into from
Nov 30, 2021

Conversation

Zidious
Copy link
Contributor

@Zidious Zidious commented Nov 29, 2021

Added support for method chaining on include and include as well as iframe CSS selectors.

Refactored the current include/exclude tests to check if the results include / exclude the correct class. Used a function from Playwright that returns the node targets within a string array.

Examples:

// include and exclude
 const builder = new AxeBuilder(driver)
        .include('.include')
        .exclude('.exclude');
// chaining include
const builder = new AxeBuilder(driver)
        .include('.include')
        .include('.include2');
// chaining exclude
const builder = new AxeBuilder(driver)
        .exclude('.exclude')
        .exclude('.exclude2');
// chaining include and exclude
const builder = new AxeBuilder(driver)
 		.include('.include')
        .include('.include2')
        .exclude('.exclude')
        .exclude('.exclude2');
// iframe selectors
const builder = new AxeBuilder(driver)
        .include(['#ifr-one', 'html'])
        .exclude(['#ifr-one', 'main']);

Closes Issue: #332 (WDJS part)

@Zidious Zidious requested a review from a team November 29, 2021 20:19
@Zidious Zidious marked this pull request as ready for review November 29, 2021 20:19
@Zidious Zidious merged commit c7c50fb into develop Nov 30, 2021
@Zidious Zidious deleted the feat/wbjs-complex-include-exclude branch November 30, 2021 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants