fix(cli): update packages to use latest version of ChromeDriver
#454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zidious
changed the title
latest version of ChromeDriver
straker
previously requested changes
Feb 11, 2022
.circleci/config.yml
Outdated
| @@ -127,6 +127,7 @@ jobs: | |||
| steps: | |||
| - checkout | |||
| - restore_dependency_cache | |||
| - run: npx browser-driver-manager@1.0.4 install chrome chromedriver | |||
There was a problem hiding this comment.
Since you're doing this for every package, probably best to install it as a dependency at the root so you don't have to waste time reinstalling it for every job.
There was a problem hiding this comment.
Chrome version is at V96 when I ran it on SSH, we would need to store Chrome in a cache or find a docker image that updates the chrome versions?
michael-siek
approved these changes
Feb 14, 2022
Zidious
changed the title
latest version of ChromeDriverlatest version of ChromeDriver
This was referenced Feb 15, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes issue: #452