Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(aria-allowed-attr): allow aria-required on role=slider #4035

Merged
merged 1 commit into from May 24, 2023
Merged

fix(aria-allowed-attr): allow aria-required on role=slider #4035

merged 1 commit into from May 24, 2023

Conversation

straker
Copy link
Contributor

@straker straker commented May 23, 2023

Tested in VO/Safari, JAWS/Chrome, and NVDA/Firefox.

Closes: #4027

@straker straker requested a review from a team as a code owner May 23, 2023 15:32
WilcoFiers
WilcoFiers approved these changes May 24, 2023
View reviewed changes
Copy link
Contributor

@WilcoFiers WilcoFiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming you looked at other input-like roles that ARIA may not have omitted this on.

@straker straker merged commit bb2bf60 into develop May 24, 2023
17 checks passed
@straker straker deleted the slider-aria-required branch May 24, 2023 15:57
This was referenced May 24, 2023
Closed
Merged
@Shubhabrata08 Shubhabrata08 mentioned this pull request Jan 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilcoFiers WilcoFiers WilcoFiers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Why is aria-required on input with type="range" a critical issue?
2 participants
@straker @WilcoFiers