Skip to content

Opening screen dumps (sd) in K9s results in Failed to launch editor error message #2538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alextricity25 opened this issue Feb 14, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@alextricity25
Copy link

image


Describe the bug
Opening screed dumps (sd) in K9s results in Failed to launch editor error message, even though my EDITOR environment variable is set.

To Reproduce

  1. Ctrl+s to save a screen dump of a pod's log
  2. Go to screen dumps (:sd)
  3. Attempt to open screen dump by hitting "Enter"

Historical Documents
When applicable please include any supporting artifacts: k9s debug logs, configurations, resource manifests, ...

Expected behavior
No error.

Screenshots
If applicable, add screenshots to help explain your problem.

Versions (please complete the following information):

  • OS: MacOS 14.2.1
  • K9s: 0.31.8
  • K8s: 1.27.7

Additional context
Add any other context about the problem here.

@derailed derailed added bug Something isn't working InProgress labels Feb 15, 2024
@derailed derailed changed the title Opening screed dumps (sd) in K9s results in Failed to launch editor error message Opening screen dumps (sd) in K9s results in Failed to launch editor error message Feb 15, 2024
derailed added a commit that referenced this issue Feb 16, 2024
@alextricity25
Copy link
Author

Can confirm that the fix works on v0.31.9! Thanks @derailed !!

placintaalexandru pushed a commit to placintaalexandru/k9s that referenced this issue Apr 3, 2024
* [Bug] fix derailed#2535

* [Bug] fix derailed#2532

* [Bug] fix derailed#2536

* [Bug] fix derailed#2533

* [Bug] fix derailed#2538

* [Maint] cleaning up

* Release notes
@flanger001
Copy link

Sorry to necropost this one but I'm getting this in v0.32.7.

OS: macOS 15.2
K9s: v0.32.7
K8s: v1.27.9

Same exact steps as OP.

@derailed
Copy link
Owner

derailed commented Jan 8, 2025

@flanger001 Thanks for the heads up!
Do you have you env vars set for KUBE_EDITOR or K9S_EDITOR? Could also be choking on the filenames??
Could you add the k9s debug logs so we can track it down?

@flanger001
Copy link

@derailed I'm sorry, I missed this notification.

Screenshot 2025-01-14 at 13 22 36

I can't give you the whole log file because it has sensitive company data in it, but I can give my session from when I ran k9s a moment ago:

k9s.log

It was already set to my existing screendump directory, hence no navigation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants