Skip to content
This repository has been archived by the owner on Apr 18, 2023. It is now read-only.

Consider rewriting song-table's row-dragging code #60

Open
derat opened this issue Mar 11, 2023 · 0 comments
Open

Consider rewriting song-table's row-dragging code #60

derat opened this issue Mar 11, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@derat
Copy link
Owner

derat commented Mar 11, 2023

The row-dragging code in the song-table component has various bugs, e.g. #45 and #49. These seem to come from the awful HTML5 drag-and-drop API, and I'm not sure if it's even possible to fix them.

Maybe I should ditch the API and instead use the approach described at https://www.redblobgames.com/making-of/draggable/. I'd probably need to write some new code to do things that the API already handles, like deciding when to start the drag (ugh, things like the drag threshold seem like they should live in the platform) and scrolling the table (which the API already doesn't do correctly).

@derat derat added the enhancement New feature or request label Mar 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant