Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usage of React's Legacy Context API throws an error in Console #43

Open
kevin-guertin opened this issue Apr 14, 2020 · 8 comments
Open

Comments

@kevin-guertin
Copy link

This project uses React's Legacy Context API and needs to be updated to use the new Context API so it does not throw an error in console.

https://reactjs.org/docs/context.html#legacy-api

image

@arielspalter
Copy link

second that!

@dennisMeeQ
Copy link

third that! I also get:
image

@arielspalter
Copy link

You guys can check out a better option:
https://www.npmjs.com/package/react-element-spinner

@derrickpelletier
Copy link
Owner

Dang! Check out the one @arielspalter linked if you need something.

btw always willing to accept PRs for these issues.

@Victorvhn
Copy link

Hello guys, I open a PR #46 with what I think is the fix for the problem.
I would be very happy if it is approved, because today I am using a fork version of this implementation, and I would like to use the original.
@derrickpelletier

@kevin-guertin
Copy link
Author

Dang! Check out the one @arielspalter linked if you need something.

btw always willing to accept PRs for these issues.

Can you please accept the above PR?

@obouchari
Copy link

obouchari commented Oct 9, 2020

Hello guys, I open a PR #46 with what I think is the fix for the problem.
I would be very happy if it is approved, because today I am using a fork version of this implementation, and I would like to use the original.
@derrickpelletier

@Victorvhn Could you please share your fork as an independent package under different name? I don't think this package is actively updated.

@Victorvhn
Copy link

Victorvhn commented Nov 21, 2020

Hello guys, I open a PR #46 with what I think is the fix for the problem.
I would be very happy if it is approved, because today I am using a fork version of this implementation, and I would like to use the original.
@derrickpelletier

@Victorvhn Could you please share your fork as an independent package under different name? I don't think this package is actively updated.

Sorry for the delay, follow the link
https://github.com/Victorvhn/react-loading-overlay
https://www.npmjs.com/package/fork-victorvhn-react-loading-overlay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants