Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React 17.x.x? #54

Open
jmbldwn opened this issue Aug 10, 2021 · 9 comments
Open

React 17.x.x? #54

jmbldwn opened this issue Aug 10, 2021 · 9 comments

Comments

@jmbldwn
Copy link

jmbldwn commented Aug 10, 2021

I'm sure I could work around this, but npm is complaining about this module while I'm trying to upgrade my project to react 17.

@tylerlindell
Copy link

I'm using npm i -S react-loading-overlay --legacy-peer-deps but npm i -S react-loading-overlay --force might work as well until React v17+ is supported unfortunately.

@landsman
Copy link

landsman commented Dec 7, 2021

Is this dead?

@YChalfari
Copy link

seems so

@DavePaurillo
Copy link

Any alternatives for this?

@CodeLikeAGirl29
Copy link

I found one!

heres the link to the npm package.

@raxod502-plaid
Copy link

@CodeLikeAGirl29 That's the same package as this repository, isn't it?

@VPPietro
Copy link

VPPietro commented Oct 5, 2022

I've got some problems with the children elements with react 18.
fixed doing:

import React from 'react';
import LoadingOverlay, { LoadingOverlayProps } from 'react-loading-overlay';

interface ILoading extends LoadingOverlayProps {
  children?: React.ReactNode
}

const Loading: React.FC<ILoading> = (props) => (<LoadingOverlay {...props} />)

export default Loading;

and using this "Loading" component

@timrobinson33
Copy link

here's one that's updated for react 17. it seems to be working for me in 18 (using legacy-peer-deps) though I've not tested for @VPPietro's issue
https://www.npmjs.com/package/@ronchalant/react-loading-overlay
https://github.com/ronchalant/react-loading-overlay

@uguremirmustafa
Copy link

I think creating another npm package is not the way to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants