Format the ahead/behind count in a locale-aware manner

[joshaber]

That should be 61,083 in 🇺🇸 and probably something else in other places.

[shiftkey]

Seems legit:

var number = 10000
number.toLocaleString()

[shiftkey]

As discussed in #1257, we should fix this properly. See electron/electron#9247 for the upstream issue and #1257 (comment) for some further context.

[shiftkey]

This idea is interesting for the future, but this is beyond the scope of our current roadmap.

I added the future-proposal label to this issue and closed it so that we won't get overwhelmed with our backlog! We will revisit this in our next planning session.

[iAmWillShepherd]

Reopening this issue now that electron/electron#15035 exists. We should be able to get a proper fix once it lands and we update electron.

[j-f1]

In #5914, @cheshire137 suggested using a “k” suffix, which would eliminate the need for locale-specific formatting.

[shiftkey]

Reopening this issue now that electron/electron#15035 exists. We should be able to get a proper fix once it lands and we update electron.

Bumping this to indicate it's currently only available in Electron 5 (currently in beta), and if it's more urgent we'd need to investigate whether we could backport the work to Electron 4.x. My gut feeling is that we can wait until we upgrade to Electron 5, but happy to discuss further...

[j-f1]

I think it’s not too urgent because (a) commits don’t come in fractions and (b) it’s likely users from countries that use commas as decimal points will have some familiarity with the use of periods, so they’d get the message. Another alternative is to switch to spaces (“61 083”) although I’m not sure how familiar the general population is with that format.