Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colours after update #7021

Closed
PeGoe opened this issue Mar 6, 2019 · 11 comments
Closed

Colours after update #7021

PeGoe opened this issue Mar 6, 2019 · 11 comments
Labels
more-info-needed The submitter needs to provide more information about the issue

Comments

@PeGoe
Copy link

PeGoe commented Mar 6, 2019

The colours of the words "Current repository, Current branch, Last fetched..." are difficult for me to read.

Please give the option to view the UI as before.

GitHub Desktop Screenshot.docx

Version

  • GitHub Desktop:
  • Operating system:

Additional Information

Logs

@shiftkey
Copy link
Member

shiftkey commented Mar 6, 2019

@PeGoe thanks for the feedback!

I've lifted the screenshot out of the document to make this easier to follow:

@shiftkey shiftkey added the more-info-needed The submitter needs to provide more information about the issue label Mar 6, 2019
@billygriffin
Copy link
Contributor

Hi @PeGoe, thanks for the issue! This seems unexpected and we haven't seen it elsewhere. Would you mind filling out the template so we can understand what version and OS and such you're using and we can try to reproduce? I'm updating your original comment with the template.

@shiftkey
Copy link
Member

shiftkey commented Mar 6, 2019

@PeGoe two other things I'd like to learn more about that aren't covered in the template:

  • Can you provide a better screenshot of the app? You can drag-and-drop images when making a comment to upload them.
  • Are there any customizations that you have to the default Desktop themes? The purple colour on the commit button is very interesting, and I want to know more about what might be causing that...

@PeGoe
Copy link
Author

PeGoe commented Mar 9, 2019 via email

@PeGoe

This comment has been minimized.

@PeGoe

This comment has been minimized.

@shiftkey
Copy link
Member

@PeGoe none of the attachments made it through. Are you able try again commenting directly on GitHub?

@PeGoe
Copy link
Author

PeGoe commented Mar 11, 2019

Screenshot:
grafik

@PeGoe
Copy link
Author

PeGoe commented Mar 11, 2019

Screenshot dark theme:
grafik

@shiftkey
Copy link
Member

shiftkey commented Mar 14, 2019

@PeGoe do you have a color profile or color correction enabled for that monitor? The reason I ask is that I was able to emulate your screenshot fairly closely by taking the default screenshot of the app and tweaking the hue and saturation in an image editor.

You'll also see that the text looks blurry up close as a result:

This isn't a 100% satisfactory answer, because some parts of your screenshot (which look like images) are not affected by this:

I was able to find this PR electron/electron#15898 which talks more about this limitation that affects Chromium and lets Electron apps opt-out of the default behaviour, but it hasn't been backported to the current version of Electron that we are using currently.

@tierninho
Copy link
Contributor

@PeGoe As we have not heard back from you on this issue, we are closing it for now. Should you have any more details or questions, please reach out and we will be happy to help. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
more-info-needed The submitter needs to provide more information about the issue
Projects
None yet
Development

No branches or pull requests

4 participants