Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resize layout problem with post welcome flow landing page #9175

Closed
niik opened this issue Feb 25, 2020 · 1 comment · Fixed by #9301
Closed

Resize layout problem with post welcome flow landing page #9175

niik opened this issue Feb 25, 2020 · 1 comment · Fixed by #9301
Assignees
Labels
bug Confirmed bugs or reports that are very likely to be bugs priority-3 Bugs that affect small number of users and/or relatively cosmetic in nature

Comments

@niik
Copy link
Member

niik commented Feb 25, 2020

Describe the bug

The post-welcome flow landing page on Windows doesn't respond as intended when being resized. Assuming this is related to #8791 or #8959 (i.e #8967).

Tentatively putting this in the 2.4 release as it appears to be a regression from what's on prod at the moment.

Version & OS

Latest development build (452c89d). Windows 10 and macOS 10.15.3

Steps to reproduce the behavior

  1. Remove all repositories to get to the post-welcome flow landing page
  2. Wait until the list of cloneable repositories has loaded
  3. Select any repository from the list such that the blue clone button shows up at the bottom of the page

image

  1. Resize the application window

Expected behavior

That the ProTip box as well as the clone button to be anchored toward the bottom of the view

image

Actual behavior

The clone button and the ProTip box are positioned outside of the bounds of the application Window.

image

Screenshots

welcome-resize-bug

Logs

N/A

@niik niik added bug Confirmed bugs or reports that are very likely to be bugs priority-3 Bugs that affect small number of users and/or relatively cosmetic in nature labels Feb 25, 2020
@niik niik added this to Backlog (unprioritized) in Desktop 2.4 release via automation Feb 25, 2020
@nerdneha nerdneha moved this from Backlog (unprioritized) to Prioritized backlog (ordered) in Desktop 2.4 release Mar 16, 2020
@rafeca
Copy link
Contributor

rafeca commented Mar 17, 2020

After looking at it for a bit I've found that this can get fixed by adding an overflow: auto property to the .filter-list-container selector.

I'm going to try to find an alternative solution since I'd prefer to not touch the styling of FilterList that is used by many other components in the app (although I don't think that the change would be risky).

@rafeca rafeca self-assigned this Mar 17, 2020
@rafeca rafeca moved this from Prioritized backlog (ordered) to In Progress PRs in Desktop 2.4 release Mar 17, 2020
@rafeca rafeca moved this from In Progress PRs to In Progress Issues in Desktop 2.4 release Mar 17, 2020
Desktop 2.4 release automation moved this from In Progress Issues to Done! Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bugs or reports that are very likely to be bugs priority-3 Bugs that affect small number of users and/or relatively cosmetic in nature
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants
@rafeca @niik and others