Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fonts are sometimes blurred on macOS Catalina #9541

Closed
zeke opened this issue Apr 16, 2020 · 8 comments
Closed

fonts are sometimes blurred on macOS Catalina #9541

zeke opened this issue Apr 16, 2020 · 8 comments
Labels
bug Confirmed bugs or reports that are very likely to be bugs electron Issues related to our use of Electron that may need updates to Electron or upstream fixes macOS Issues specific to Desktop usage on macOS priority-3 Bugs that affect small number of users and/or relatively cosmetic in nature

Comments

@zeke
Copy link
Contributor

zeke commented Apr 16, 2020

I’ve noticed that sometimes my fonts get blurry in Desktop on macOS Catalina. Quitting and restarting the app takes care of it.

Note that in the blurry screenshot below, there's a banner at the top of the Window about a new Desktop version. I am unsure whether that is a factor in making the window blurry, but I will follow up when and if I see this again.

Environment: macOS Catalina


Blurry:

blurry


Crisp:

crisp

@rafeca
Copy link
Contributor

rafeca commented Apr 17, 2020

Thanks for the report @zeke !! Based on the screenshot it looks that not only the fonts but also the SVGs and even the images are blurry (your avatar also looks blurry right?).

I have no idea what could be happening here, but it may be electron related. Does it happen often?

If you get to experience the issue again can you open the Dev tools (Cmd + Opt + I) and check if the window is zoomed? (whether window.devicePixelRatio returns something different than 2 for a retina display).

@rafeca rafeca added the more-info-needed The submitter needs to provide more information about the issue label Apr 17, 2020
@zeke
Copy link
Contributor Author

zeke commented Apr 17, 2020

Does it happen often?

I've noticed it three times in the last month.

@zeke
Copy link
Contributor Author

zeke commented Apr 22, 2020

Update: I see a new version banner atop my GitHub Desktop window, but it has NOT caused any blurring, so that is likely ruled out as a possible cause of the issue:

Screen Shot 2020-04-21 at 7 39 27 PM

@zeke
Copy link
Contributor Author

zeke commented Apr 28, 2020

It happened again. I think it may occur when I disconnect my running MacBook Pro from my Thunderbolt display.

@zeke
Copy link
Contributor Author

zeke commented Apr 28, 2020

Oh and quitting and restarting the app resolved the issue.

@tierninho tierninho added bug Confirmed bugs or reports that are very likely to be bugs electron Issues related to our use of Electron that may need updates to Electron or upstream fixes priority-3 Bugs that affect small number of users and/or relatively cosmetic in nature and removed more-info-needed The submitter needs to provide more information about the issue labels Apr 28, 2020
@tierninho
Copy link
Contributor

Look like this will be fixed in v7.1.11 per here electron/electron#21393. We are on 7.1.8, per here https://github.com/desktop/desktop/blob/development/package.json#L170

@adamreisnz
Copy link

I can confirm that this happens when disconnecting a thunderbolt USB-C attached display. The whole app becomes blurry (not just fonts):

image

Restarting app fixes it.

@sergiou87 sergiou87 added this to Triage in Desktop Housekeeping via automation Apr 12, 2021
@say25 say25 added the macOS Issues specific to Desktop usage on macOS label Aug 24, 2021
@steveward
Copy link
Member

I'm going to close this out as stale since it's 4 years old, but if this is still an issue for anyone we can reopen and investigate.

Desktop Housekeeping automation moved this from Triage to Done Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bugs or reports that are very likely to be bugs electron Issues related to our use of Electron that may need updates to Electron or upstream fixes macOS Issues specific to Desktop usage on macOS priority-3 Bugs that affect small number of users and/or relatively cosmetic in nature
Development

No branches or pull requests

7 participants
@zeke @rafeca @adamreisnz @steveward @say25 @tierninho and others