Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash reports from Sentry - read ENOTCONN #9710

Closed
billygriffin opened this issue May 5, 2020 · 5 comments
Closed

Crash reports from Sentry - read ENOTCONN #9710

billygriffin opened this issue May 5, 2020 · 5 comments
Labels
electron Issues related to our use of Electron that may need updates to Electron or upstream fixes macOS Issues specific to Desktop usage on macOS

Comments

@billygriffin
Copy link
Contributor

Describe the bug

We're seeing a crash report with the error read ENOTCONN

Version & OS

Seems to be specific to macOS and 2.4+

@billygriffin billygriffin changed the title Crash reports from Sentry Crash reports from Sentry - read ENOTCONN May 5, 2020
@billygriffin billygriffin added the electron Issues related to our use of Electron that may need updates to Electron or upstream fixes label May 5, 2020
@outofambit
Copy link
Contributor

outofambit commented May 5, 2020

These are likely caused by nodejs/node#26315, which we likely inherited when we moved to electron v7.x. This wasn’t fixed in nodejs until in the v12.13.1 release, which isn’t included in electron v7.x. (They’ve only upgraded it to nodejs v12.8.1.) The next release of Electron (v8.2.6) will likely include a version of nodejs with the fix for this. From later comment: It did not, it turns out. but electron v9.0.0 did. (it has nodejs v12.14.1)

@outofambit outofambit added the macOS Issues specific to Desktop usage on macOS label May 5, 2020
@plivesey
Copy link

plivesey commented May 8, 2020

The app crashes consistently on launch for me. Is there a workaround to fix this locally? It suddenly started happening and I'm not sure what changed.

Error: read ENOTCONN
    at Socket._read (net.js:530:20)
    at Socket.Readable.read (_stream_readable.js:481:10)
    at new Socket (net.js:328:12)
    at Object.Socket (net.js:237:41)
    at createSocket (internal/child_process.js:311:14)
    at ChildProcess.spawn (internal/child_process.js:424:23)
    at spawn (child_process.js:553:9)
    at Object.execFile (child_process.js:237:17)
    at Object.module.<computed> [as execFile] (electron/js2c/asar.js:163:31)
    at file:///app/renderer.js:16:254915

Version: 2.4.3
OS: Mac OS 10.15.4```

@plivesey
Copy link

plivesey commented May 8, 2020

Looks like for me it was because I had too many processes running. My whole computer was bricked: fork: Resource temporarily unavailable. I needed to go to Activity Monitor and kill a process which had 1000s of copies of itself.

The service is DTServiceHub which seems to be an Xcode related service. So I think my original cause was a bug in Xcode which bricks your computer.

@outofambit outofambit added this to Backlog (unprioritized) in Desktop 2.5.x releases via automation May 14, 2020
@outofambit
Copy link
Contributor

The next release of Electron (v8.2.6) will likely include a version of nodejs with the fix for this.

It did not, it turns out. but electron v9.0.0 did. (it has nodejs v12.14.1)

@billygriffin
Copy link
Contributor Author

Since we're now on Electron 9, I think this should be fixed. Please let us know if you run into this issue again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
electron Issues related to our use of Electron that may need updates to Electron or upstream fixes macOS Issues specific to Desktop usage on macOS
Projects
No open projects
Development

No branches or pull requests

3 participants