Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

> I think the title is not matched with the changes. It should be Add "View in your browser" to replace "View on GitHub" if the repository is not hosted on GitHub #3

Open
ProfetaXXIV opened this issue Jan 18, 2024 · 2 comments

Comments

@ProfetaXXIV
Copy link

          > I think the title is not matched with the changes. It should be Add "View in your browser" to replace "View on GitHub" if the repository is not hosted on GitHub

Thanks

EDIT: In the PR it's now "View in Browser"

And why don't we replace the "View on GitHub" completely with "View in your browser"?

I've just left the decision to the GitHub staff. (I am just an outside contributor)

Originally posted by @novialriptide in desktop/desktop#17867 (comment)

17055742796146865071167456340362

@ProfetaXXIV
Copy link
Author

          > I think the title is not matched with the changes. It should be Add "View in your browser" to replace "View on GitHub" if the repository is not hosted on GitHub

Thanks

EDIT: In the PR it's now "View in Browser"

And why don't we replace the "View on GitHub" completely with "View in your browser"?

I've just left the decision to the GitHub staff. (I am just an outside contributor)

Originally posted by @novialriptide in desktop/desktop#17867 (comment)

17055742796146865071167456340362

Yo @niik

@ProfetaXXIV
Copy link
Author

Yo soi. The king Kong

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant