Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add prebuild targets for Electron 7 #171

Merged
merged 1 commit into from Oct 24, 2019
Merged

add prebuild targets for Electron 7 #171

merged 1 commit into from Oct 24, 2019

Conversation

ottosson
Copy link
Contributor

@ottosson ottosson commented Oct 24, 2019 •
edited

This PR adds prebuild targets for Electron 7 and updates the node-abi dependency to latest version.
Refers to #170

shiftkey
shiftkey approved these changes Oct 24, 2019
View reviewed changes
Copy link
Member

@shiftkey shiftkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ottosson thanks for the contribution!

I'm going to see if I can publish a release today with this change.

@shiftkey shiftkey merged commit 0dd18f0 into desktop:master Oct 24, 2019
@ottosson
Copy link
Contributor Author

That would be great. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shiftkey shiftkey shiftkey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ottosson @shiftkey