Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support writing tests in C++ to test internals better #28

Open
shiftkey opened this issue Dec 5, 2017 · 3 comments
Open

support writing tests in C++ to test internals better #28

shiftkey opened this issue Dec 5, 2017 · 3 comments

Comments

@shiftkey
Copy link
Member

shiftkey commented Dec 5, 2017

From #27

Need to add a test for dodgy non-null-terminated data, but I'm not sure the best way to actually get this into the registry in the first place, since REG.EXE is going to do it correctly. Can we add adjunct C++ programs to the test code somehow?

@Porges what your preferred C++ test framework for this sort of thing?

@Porges
Copy link
Contributor

Porges commented Dec 5, 2017

Nearly got something going but it crashes when I try to link it against the node functions and I don't know why yet 😁

@Porges
Copy link
Contributor

Porges commented Dec 5, 2017

Blergh; wasn't setting up the V8 platform abstraction before calling Initialize (why not use a normal class, eh?)

But CreateDefaultPlatform isn't exported from Node, so this can't link... Porges@6caf63f Will have to figure something out later.

@shiftkey
Copy link
Member Author

shiftkey commented Dec 6, 2017

I'm not entirely sure about this one. I'll do some digging and see if I can't spot a way out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants