/
LabeledExpressionSpec.kt
175 lines (159 loc) · 4.99 KB
/
LabeledExpressionSpec.kt
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
package io.gitlab.arturbosch.detekt.rules.complexity
import io.gitlab.arturbosch.detekt.test.TestConfig
import io.gitlab.arturbosch.detekt.test.assertThat
import io.gitlab.arturbosch.detekt.test.compileAndLint
import org.junit.jupiter.api.Test
class LabeledExpressionSpec {
private val subject = LabeledExpression()
@Test
fun `reports break and continue labels`() {
val code = """
fun f() {
loop@ for (i in 1..3) {
for (j in 1..3) {
if (j == 4) break@loop
if (j == 5) continue@loop
}
}
}
""".trimIndent()
assertThat(subject.compileAndLint(code)).hasSize(3)
}
@Test
fun `reports implicit return label`() {
val code = """
fun f(range: IntRange) {
range.forEach {
if (it == 5) return@forEach
println(it)
}
}
""".trimIndent()
val findings = subject.compileAndLint(code)
assertThat(findings).hasSize(1)
assertThat(findings).hasStartSourceLocation(3, 28)
}
@Test
fun `reports explicit return label`() {
val code = """
fun f(range: IntRange) {
range.forEach label@{
if (it == 5) return@label
println(it)
}
}
""".trimIndent()
assertThat(subject.compileAndLint(code)).hasSize(2)
}
@Test
fun `reports labels referencing inner and outer class`() {
val code = """
class Outer {
inner class Inner {
fun f() {
val i = this@Inner
emptyList<Int>().forEach Outer@{
// references forEach label and not outer class
if (it == 5) return@Outer
println(it)
}
}
}
}
""".trimIndent()
assertThat(subject.compileAndLint(code)).hasSize(3)
}
@Test
fun `does not report inner class referencing outer class`() {
val code = """
class Outer {
inner class Inner {
fun f() {
print(this@Outer)
}
}
}
""".trimIndent()
assertThat(subject.compileAndLint(code)).isEmpty()
}
@Test
fun `does not report inner class referencing outer class in extension function`() {
val code = """
class Outer {
inner class Inner {
fun Int.f() {
print(this@Inner)
print(this@Outer)
}
}
}
""".trimIndent()
assertThat(subject.compileAndLint(code)).isEmpty()
}
@Test
fun `does not report nested class referencing outer class in extension function`() {
val code = """
class Outer {
class Nested {
fun Int.f() {
print(this@Nested)
}
}
}
""".trimIndent()
assertThat(subject.compileAndLint(code)).isEmpty()
}
@Test
fun `does not report inner classes referencing outer class in extension function`() {
val code = """
class Outer {
inner class Inner {
inner class InnerInner {
fun f() {
print(this@Outer)
print(this@Inner)
}
fun Int.f() {
print(this@Inner)
print(this@InnerInner)
}
}
}
}
""".trimIndent()
assertThat(subject.compileAndLint(code)).isEmpty()
}
@Test
fun `does not report excluded label`() {
val code = """
fun f() {
loop@ for (i in 1..5) {}
}
""".trimIndent()
val config = TestConfig(mapOf("ignoredLabels" to listOf("loop")))
val findings = LabeledExpression(config).compileAndLint(code)
assertThat(findings).isEmpty()
}
@Test
fun `does not report excluded label config with string`() {
val code = """
fun f() {
loop@ for (i in 1..5) {}
}
""".trimIndent()
val config = TestConfig(mapOf("ignoredLabels" to "loop"))
val findings = LabeledExpression(config).compileAndLint(code)
assertThat(findings).isEmpty()
}
@Test
fun `does not report excluded label config with leading and trailing wildcard`() {
val code = """
fun f() {
loop@ for (i in 1..5) {}
}
""".trimIndent()
val config = TestConfig(mapOf("ignoredLabels" to "*loop*,other"))
val findings = LabeledExpression(config).compileAndLint(code)
assertThat(findings).isEmpty()
}
}