/
UnnecessaryNotNullOperator.kt
54 lines (49 loc) · 1.71 KB
/
UnnecessaryNotNullOperator.kt
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
package io.gitlab.arturbosch.detekt.rules.bugs
import io.gitlab.arturbosch.detekt.api.CodeSmell
import io.gitlab.arturbosch.detekt.api.Config
import io.gitlab.arturbosch.detekt.api.Debt
import io.gitlab.arturbosch.detekt.api.Entity
import io.gitlab.arturbosch.detekt.api.Issue
import io.gitlab.arturbosch.detekt.api.Rule
import io.gitlab.arturbosch.detekt.api.Severity
import io.gitlab.arturbosch.detekt.api.internal.ActiveByDefault
import io.gitlab.arturbosch.detekt.api.internal.RequiresTypeResolution
import org.jetbrains.kotlin.diagnostics.Errors
import org.jetbrains.kotlin.psi.KtUnaryExpression
/**
* Reports unnecessary not-null operator usage (!!) that can be removed by the user.
*
* <noncompliant>
* val a = 1
* val b = a!!
* </noncompliant>
*
* <compliant>
* val a = 1
* val b = a
* </compliant>
*/
@RequiresTypeResolution
@ActiveByDefault(since = "1.16.0")
class UnnecessaryNotNullOperator(config: Config = Config.empty) : Rule(config) {
override val issue: Issue = Issue(
"UnnecessaryNotNullOperator",
Severity.Defect,
"Unnecessary not-null unary operator (!!) detected.",
Debt.FIVE_MINS
)
override fun visitUnaryExpression(expression: KtUnaryExpression) {
super.visitUnaryExpression(expression)
val compilerReports = bindingContext.diagnostics.forElement(expression.operationReference)
if (compilerReports.any { it.factory == Errors.UNNECESSARY_NOT_NULL_ASSERTION }) {
report(
CodeSmell(
issue,
Entity.from(expression),
"${expression.text} contains an unnecessary " +
"not-null (!!) operators"
)
)
}
}
}