-
-
Notifications
You must be signed in to change notification settings - Fork 757
/
WorkaroundConfigurationKtSpec.kt
191 lines (163 loc) · 7.74 KB
/
WorkaroundConfigurationKtSpec.kt
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
package io.gitlab.arturbosch.detekt.core
import io.github.detekt.test.utils.resourceUrl
import io.github.detekt.tooling.api.spec.ProcessingSpec
import io.gitlab.arturbosch.detekt.core.config.loadConfiguration
import org.assertj.core.api.Assertions.assertThat
import org.junit.jupiter.api.Nested
import org.junit.jupiter.api.Test
class WorkaroundConfigurationKtSpec {
@Nested
inner class `with all rules activated by default` {
private val config = ProcessingSpec {
config { resources = listOf(resourceUrl("/configs/empty.yml")) }
rules { activateAllRules = true }
}.let { spec ->
spec.workaroundConfiguration(spec.loadConfiguration())
}
@Test
fun `should override active to true by default`() {
val actual = config.subConfig("comments")
.subConfig("UndocumentedPublicClass")
.valueOrDefault("active", false)
assertThat(actual).isEqualTo(true)
}
@Test
fun `should override maxIssues to 0 by default`() {
assertThat(config.subConfig("build").valueOrDefault("maxIssues", -1)).isEqualTo(0)
}
@Test
fun `should keep config from default`() {
val actual = config.subConfig("style")
.subConfig("MaxLineLength")
.valueOrDefault("maxLineLength", -1)
assertThat(actual).isEqualTo(120)
}
}
@Nested
inner class `activate all rules override` {
private val config = ProcessingSpec {
config { resources = listOf(resourceUrl("/configs/activate-all-rules-will-override-here.yml")) }
rules { activateAllRules = true }
}.let { spec ->
spec.workaroundConfiguration(spec.loadConfiguration())
}
@Test
fun `should override config when specified`() {
val actual = config.subConfig("style")
.subConfig("MaxLineLength")
.valueOrDefault("maxLineLength", -1)
assertThat(actual).isEqualTo(100)
}
@Test
fun `should override active when specified`() {
val actual = config.subConfig("comments")
.subConfig("CommentOverPrivateMethod")
.valueOrDefault("active", true)
assertThat(actual).isEqualTo(false)
}
@Test
fun `should override maxIssues when specified`() {
assertThat(config.subConfig("build").valueOrDefault("maxIssues", -1)).isEqualTo(1)
}
}
@Nested
inner class `auto correct config` {
@Nested
inner class `when specified it respects all autoCorrect values of rules and rule sets` {
private val config = ProcessingSpec {
config { resources = listOf(resourceUrl("/configs/config-with-auto-correct.yml")) }
rules { autoCorrect = true }
}.let { spec ->
spec.workaroundConfiguration(spec.loadConfiguration())
}
private val style = config.subConfig("style")
private val comments = config.subConfig("comments")
@Test
fun `is disabled for rule sets`() {
assertThat(style.valueOrNull<Boolean>("autoCorrect")).isTrue()
assertThat(comments.valueOrNull<Boolean>("autoCorrect")).isFalse()
}
@Test
fun `is disabled for rules`() {
assertThat(style.subConfig("MagicNumber").valueOrNull<Boolean>("autoCorrect")).isTrue()
assertThat(style.subConfig("MagicString").valueOrNull<Boolean>("autoCorrect")).isFalse()
assertThat(comments.subConfig("ClassDoc").valueOrNull<Boolean>("autoCorrect")).isTrue()
assertThat(comments.subConfig("FunctionDoc").valueOrNull<Boolean>("autoCorrect")).isFalse()
}
}
@Nested
inner class `when not specified all autoCorrect values are overridden to false` {
private val config = ProcessingSpec {
config { resources = listOf(resourceUrl("/configs/config-with-auto-correct.yml")) }
}.let { spec ->
spec.workaroundConfiguration(spec.loadConfiguration())
}
private val style = config.subConfig("style")
private val comments = config.subConfig("comments")
@Test
fun `is disabled for rule sets`() {
assertThat(style.valueOrNull<Boolean>("autoCorrect")).isFalse()
assertThat(comments.valueOrNull<Boolean>("autoCorrect")).isFalse()
}
@Test
fun `is disabled for rules`() {
assertThat(style.subConfig("MagicNumber").valueOrNull<Boolean>("autoCorrect")).isFalse()
assertThat(style.subConfig("MagicString").valueOrNull<Boolean>("autoCorrect")).isFalse()
assertThat(comments.subConfig("ClassDoc").valueOrNull<Boolean>("autoCorrect")).isFalse()
assertThat(comments.subConfig("FunctionDoc").valueOrNull<Boolean>("autoCorrect")).isFalse()
}
}
@Nested
inner class `when specified as false, all autoCorrect values are overridden to false` {
private val config = ProcessingSpec {
config { resources = listOf(resourceUrl("/configs/config-with-auto-correct.yml")) }
rules { autoCorrect = false }
}.let { spec ->
spec.workaroundConfiguration(spec.loadConfiguration())
}
private val style = config.subConfig("style")
private val comments = config.subConfig("comments")
@Test
fun `is disabled for rule sets`() {
assertThat(style.valueOrNull<Boolean>("autoCorrect")).isFalse()
assertThat(comments.valueOrNull<Boolean>("autoCorrect")).isFalse()
}
@Test
fun `is disabled for rules`() {
assertThat(style.subConfig("MagicNumber").valueOrNull<Boolean>("autoCorrect")).isFalse()
assertThat(style.subConfig("MagicString").valueOrNull<Boolean>("autoCorrect")).isFalse()
assertThat(comments.subConfig("ClassDoc").valueOrNull<Boolean>("autoCorrect")).isFalse()
assertThat(comments.subConfig("FunctionDoc").valueOrNull<Boolean>("autoCorrect")).isFalse()
}
}
@Nested
inner class `regardless of other cli options, autoCorrect values are overridden to false` {
private val config = ProcessingSpec {
config {
useDefaultConfig = true
resources = listOf(resourceUrl("/configs/config-with-auto-correct.yml"))
}
rules {
autoCorrect = false
activateAllRules = true
}
}.let { spec ->
spec.workaroundConfiguration(spec.loadConfiguration())
}
private val style = config.subConfig("style")
private val comments = config.subConfig("comments")
@Test
fun `is disabled for rule sets`() {
assertThat(style.valueOrNull<Boolean>("autoCorrect")).isFalse()
assertThat(comments.valueOrNull<Boolean>("autoCorrect")).isFalse()
}
@Test
fun `is disabled for rules`() {
assertThat(style.subConfig("MagicNumber").valueOrNull<Boolean>("autoCorrect")).isFalse()
assertThat(style.subConfig("MagicString").valueOrNull<Boolean>("autoCorrect")).isFalse()
assertThat(comments.subConfig("ClassDoc").valueOrNull<Boolean>("autoCorrect")).isFalse()
assertThat(comments.subConfig("FunctionDoc").valueOrNull<Boolean>("autoCorrect")).isFalse()
}
}
}
}