-
-
Notifications
You must be signed in to change notification settings - Fork 757
/
UselessCallOnNotNullSpec.kt
274 lines (240 loc) · 10.3 KB
/
UselessCallOnNotNullSpec.kt
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
package io.gitlab.arturbosch.detekt.rules.style
import io.gitlab.arturbosch.detekt.rules.KotlinCoreEnvironmentTest
import io.gitlab.arturbosch.detekt.test.compileAndLintWithContext
import io.gitlab.arturbosch.detekt.test.lintWithContext
import org.assertj.core.api.Assertions.assertThat
import org.jetbrains.kotlin.cli.jvm.compiler.KotlinCoreEnvironment
import org.junit.jupiter.api.Test
@KotlinCoreEnvironmentTest
class UselessCallOnNotNullSpec(val env: KotlinCoreEnvironment) {
val subject = UselessCallOnNotNull()
@Test
fun `reports when calling orEmpty on a list`() {
val code = """val testList = listOf("string").orEmpty()"""
val findings = subject.compileAndLintWithContext(env, code)
assertThat(findings).hasSize(1)
assertThat(findings[0].message).isEqualTo("Remove redundant call to orEmpty")
}
@Test
fun `reports when calling orEmpty on a list with a safe call`() {
val code = """val testList = listOf("string")?.orEmpty()"""
val findings = subject.compileAndLintWithContext(env, code)
assertThat(findings).hasSize(1)
assertThat(findings[0].message).isEqualTo("Remove redundant call to orEmpty")
}
@Test
fun `reports when calling orEmpty on a list in a chain`() {
val code = """val testList = listOf("string").orEmpty().map { }"""
val findings = subject.compileAndLintWithContext(env, code)
assertThat(findings).hasSize(1)
assertThat(findings[0].message).isEqualTo("Remove redundant call to orEmpty")
}
@Test
fun `reports when calling orEmpty on a list with a platform type`() {
// System.getenv().keys.toList() will be of type List<String!>.
val code = """val testSequence = System.getenv().keys.toList().orEmpty()"""
val findings = subject.compileAndLintWithContext(env, code)
assertThat(findings).hasSize(1)
assertThat(findings[0].message).isEqualTo("Remove redundant call to orEmpty")
}
@Test
fun `does not report when calling orEmpty on a nullable list`() {
val code = """
val testList: List<String>? = listOf("string")
val nonNullableTestList = testList.orEmpty()
"""
assertThat(subject.compileAndLintWithContext(env, code)).isEmpty()
}
@Test
fun `reports when calling isNullOrBlank on a string with a safe call`() {
val code = """val testString = ""?.isNullOrBlank()"""
val findings = subject.compileAndLintWithContext(env, code)
assertThat(findings).hasSize(1)
assertThat(findings[0].message).isEqualTo("Replace isNullOrBlank with isBlank")
}
@Test
fun `does not report when calling isNullOrBlank on a nullable string`() {
val code = """
val testString: String? = ""
val nonNullableTestString = testString.isNullOrBlank()
"""
assertThat(subject.compileAndLintWithContext(env, code)).isEmpty()
}
@Test
fun `reports when calling isNullOrEmpty on a string`() {
val code = """val testString = "".isNullOrEmpty()"""
val findings = subject.compileAndLintWithContext(env, code)
assertThat(findings).hasSize(1)
assertThat(findings[0].message).isEqualTo("Replace isNullOrEmpty with isEmpty")
}
@Test
fun `reports when calling isNullOrEmpty on a string with a safe call`() {
val code = """val testString = ""?.isNullOrEmpty()"""
assertThat(subject.compileAndLintWithContext(env, code)).hasSize(1)
}
@Test
fun `does not report when calling isNullOrEmpty on a nullable string`() {
val code = """
val testString: String? = ""
val nonNullableTestString = testString.isNullOrEmpty()
"""
assertThat(subject.compileAndLintWithContext(env, code)).isEmpty()
}
@Test
fun `reports when calling orEmpty on a string`() {
val code = """val testString = "".orEmpty()"""
val findings = subject.compileAndLintWithContext(env, code)
assertThat(findings).hasSize(1)
assertThat(findings[0].message).isEqualTo("Remove redundant call to orEmpty")
}
@Test
fun `does not report when calling orEmpty on a nullable string`() {
val code = """
val testString: String? = ""
val nonNullableTestString = testString.orEmpty()
"""
assertThat(subject.compileAndLintWithContext(env, code)).isEmpty()
}
@Test
fun `reports when calling orEmpty on a sequence`() {
val code = """val testSequence = listOf(1).asSequence().orEmpty()"""
val findings = subject.compileAndLintWithContext(env, code)
assertThat(findings).hasSize(1)
assertThat(findings[0].message).isEqualTo("Remove redundant call to orEmpty")
}
@Test
fun `does not report when calling orEmpty on a nullable sequence`() {
val code = """
val testSequence: Sequence<Int>? = listOf(1).asSequence()
val nonNullableTestSequence = testSequence.orEmpty()
"""
assertThat(subject.compileAndLintWithContext(env, code)).isEmpty()
}
@Test
fun `only reports on a Kotlin list`() {
val code = """
fun String.orEmpty(): List<Char> = this.toCharArray().asList()
val noList = "str".orEmpty()
val list = listOf(1, 2, 3).orEmpty()
"""
val findings = subject.compileAndLintWithContext(env, code)
assertThat(findings).hasSize(1)
assertThat(findings[0].message).isEqualTo("Remove redundant call to orEmpty")
}
@Test
fun `reports when calling listOfNotNull on all non-nullable arguments`() {
val code = """
val strings = listOfNotNull("string")
"""
val findings = subject.compileAndLintWithContext(env, code)
assertThat(findings).hasSize(1)
assertThat(findings[0].message).isEqualTo("Replace listOfNotNull with listOf")
}
@Test
fun `reports when calling listOfNotNull with no arguments`() {
val code = """
val strings = listOfNotNull<String>()
"""
val findings = subject.compileAndLintWithContext(env, code)
assertThat(findings).hasSize(1)
assertThat(findings[0].message).isEqualTo("Replace listOfNotNull with listOf")
}
@Test
fun `does not report when calling listOfNotNull on at least one nullable argument`() {
val code = """
val strings = listOfNotNull("string", null)
"""
val findings = subject.compileAndLintWithContext(env, code)
assertThat(findings).isEmpty()
}
@Test
fun `does not report when calling listOfNotNull with spread operator`() {
val code = """
val nullableArray = arrayOf("string", null)
val strings = listOfNotNull(*nullableArray)
"""
val findings = subject.compileAndLintWithContext(env, code)
assertThat(findings).isEmpty()
}
@Test
fun `reports when calling listOfNotNull with spread operator on all non-nullable arguments`() {
val code = """
val nonNullableArray = arrayOf("string", "bar")
val strings = listOfNotNull(*nonNullableArray)
"""
val findings = subject.compileAndLintWithContext(env, code)
assertThat(findings).hasSize(1)
assertThat(findings[0].message).isEqualTo("Replace listOfNotNull with listOf")
}
@Test
fun `does not report when calling listOfNotNull with a mix of null spread and non-null non-spread`() {
val code = """
val nullableArray = arrayOf("string", null)
val nonNullableArray = arrayOf("string", "bar")
val strings = listOfNotNull("string", *nonNullableArray, "foo", *nullableArray)
"""
val findings = subject.compileAndLintWithContext(env, code)
assertThat(findings).isEmpty()
}
@Test
fun `does not report when calling listOfNotNull with a mix of non-null spread and null non-spread`() {
val code = """
val nonNullableArray = arrayOf("string", "bar")
val strings = listOfNotNull("string", *nonNullableArray, null)
"""
val findings = subject.compileAndLintWithContext(env, code)
assertThat(findings).isEmpty()
}
@Test
fun `reports when calling listOfNotNull with a mix of spread and non-spread, all non-null`() {
val code = """
val nonNullableArray = arrayOf("string", "bar")
val otherNonNullableArray = arrayOf("foobar")
val strings = listOfNotNull("string", *nonNullableArray, "foo", *otherNonNullableArray)
"""
val findings = subject.compileAndLintWithContext(env, code)
assertThat(findings).hasSize(1)
assertThat(findings[0].message).isEqualTo("Replace listOfNotNull with listOf")
}
@Test
fun `does not report when calling custom function named listOfNotNull on all non-nullable arguments`() {
val code = """
fun <T : Any> listOfNotNull(vararg elements: T?): List<T> = TODO()
val strings = listOfNotNull("string", null)
"""
val findings = subject.compileAndLintWithContext(env, code)
assertThat(findings).isEmpty()
}
@Test
fun `does not report when calling listOfNotNull with values whose type is unknown`() {
val code = """
fun test() {
listOfNotNull(unknown)
}
""".trimIndent()
val findings = subject.lintWithContext(env, code)
assertThat(findings).isEmpty()
}
@Test
fun `does not report when calling listOfNotNull with values whose type is derived and unknown`() {
val code = """
import kotlin.random.Random
fun test() {
listOfNotNull(unknown.takeIf { Random.nextBoolean() })
}
""".trimIndent()
val findings = subject.lintWithContext(env, code)
assertThat(findings).isEmpty()
}
@Test
fun `reports when calling isNullOrEmpty on a list`() {
val code = """
fun test(list: List<Int>) {
list.isNullOrEmpty()
}
"""
val findings = subject.compileAndLintWithContext(env, code)
assertThat(findings).hasSize(1)
assertThat(findings[0].message).isEqualTo("Replace isNullOrEmpty with isEmpty")
}
}